feat: NaCl with ECDH encryption #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Feb 1, 2020
| } | ||
|
|
||
| data, err = bytesDecode(data) | ||
| sharedSecret, err := d.keyExchange.SharedSecret(d.privateKey, pubKey) |
There was a problem hiding this comment.
assignments should only be cuddled with other assignments (from wsl)
| default: | ||
| err = errors.New("unsupported public key") | ||
| } | ||
| return |
There was a problem hiding this comment.
return statements should not be cuddled if block has more than two lines (from wsl)
| if err != nil { | ||
| return nil, err | ||
| } | ||
| pkLen := len(pkBytes) |
There was a problem hiding this comment.
assignments should only be cuddled with other assignments (from wsl)
crypto/cipher/nacl/encoding.go
Outdated
| } | ||
|
|
||
| return raw[1:], nil | ||
| if len(raw) < 35 { |
There was a problem hiding this comment.
if statements should only be cuddled with assignments (from wsl)
| if len(raw) < 35 { | ||
| return nil, nil, errors.Errorf("cipher is too short") | ||
| } | ||
| switch raw[1] { |
There was a problem hiding this comment.
only one cuddle assignment allowed before switch statement (from wsl)
| default: | ||
| return nil, nil, errors.New("unrecognized pubKeyID") | ||
| } | ||
| return cph, pubKey, err |
There was a problem hiding this comment.
return statements should not be cuddled if block has more than two lines (from wsl)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #482