Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nacl encrypter does not encrypt messages correctly #482

Closed
4 tasks
robdefeo opened this issue Jan 2, 2020 · 2 comments · Fixed by #529
Closed
4 tasks

nacl encrypter does not encrypt messages correctly #482

robdefeo opened this issue Jan 2, 2020 · 2 comments · Fixed by #529

Comments

@robdefeo
Copy link
Member

robdefeo commented Jan 2, 2020

Is your feature request related to a problem? Please describe.
crypto/cipher/nacl uses SecretBox which is for symmetric encryption, this means that the implementation is incorrect it should of used Box. nacl.Box does not support ed25519 and sr25519 only x25519 so can not be used.

Describe the solution you'd like

Currently nacl is not used in to send any messages so it can safely be removed.

  • remove crypto/cipher/nacl
  • remove all references to crypto/cipher/nacl
  • remove NACL byte = 0x2a from crypto/cipher/cipher.go
  • remove all references to ciper.NACL
developerfred added a commit to developerfred/mailchain that referenced this issue Jan 4, 2020
@developerfred
Copy link
Contributor

  • remove crypto/cipher/nacl
  • remove all references to crypto/cipher/nacl
  • remove NACL byte = 0x2a from crypto/cipher/cipher.go
  • remove all references to ciper.NACL

developerfred added a commit to developerfred/mailchain that referenced this issue Jan 4, 2020
@robdefeo
Copy link
Member Author

robdefeo commented Feb 1, 2020

With the key exchange interface #497 and implementations in secp256k1 #501 , ed25519 #504, and
sr25519 #505 and fix #528 it is now possible to the ECHD keys exchange for these key types and generate a shared secret which can be used with secretbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants