Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

feat: add envelope and encryption-method-name #121

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Conversation

tboeckmann
Copy link
Member

closes #114 & #115

@todo
Copy link

todo bot commented Nov 26, 2019

add test for: should error on send if envelope type is empty in the outbound mail

// TODO add test for: should error on send if envelope type is empty in the outbound mail
// let outboundMailObject = mailchainTestService.outboundMailObject()
// outboundMailObject.envelope = ""
})
it('should specify encryption-method-name as "aes256cbc" in the outbound mail', () => {


This comment was generated by todo based on a TODO comment in d09afc6 in #121. cc @mailchain.

@todo
Copy link

todo bot commented Nov 26, 2019

add test for: should error on send if encryption-method-name is empty in the outbound mail

// TODO add test for: should error on send if encryption-method-name is empty in the outbound mail
// let outboundMailObject = mailchainTestService.outboundMailObject()
// outboundMailObject["encryption-method-name"] = ""
})
})
});


This comment was generated by todo based on a TODO comment in d09afc6 in #121. cc @mailchain.

@tboeckmann
Copy link
Member Author

Example POST from send:

feat: Set envelope on send message #114

{
  "message": {
    "body": "Today was a little rainy in London",
    "headers": {
      "from": "0x92d8f10248c6a3953cc3692a894655ad05d61efb",
      "reply-to": "0x92d8f10248c6a3953cc3692a894655ad05d61efb",
      "to": "0xd5ab4ce3605cd590db609b6b5c8901fdb2ef7fe6"
    },
    "public-key": "0x69d908510e355beb1d5bf2df8129e5b6401e1969891e8016a0b2300739bbb00687055e5924a2fd8dd35f069dc14d8147aa11c1f7e2f271573487e1beeb2be9d0",
    "subject": "Tuesday report"
  },
  "envelope": "0x01",
  "encryption-method-name": "aes256cbc"
}

@robdefeo
Copy link
Member

@tboeckmann yes this looks good for this phase. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send message requires envelope to be set
2 participants