This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
WIP: #239 #248
Closed
WIP: #239 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboeckmann
suggested changes
Apr 11, 2021
tboeckmann
suggested changes
Aug 17, 2021
| @@ -15,6 +17,7 @@ import { ModalConnectivityErrorComponent } from 'src/app/modals/modal-connectivi | |||
|
|
|||
| import * as ClassicEditor from '@ckeditor/ckeditor5-build-classic'; | |||
| import { CKEditorComponent } from '@ckeditor/ckeditor5-angular'; | |||
| import { getCurrencySymbol } from '@angular/common'; | |||
| "type": 4, | ||
| "body": { | ||
| "balance": 2183846200000000000, | ||
| "unit": "wei" |
There was a problem hiding this comment.
Can you check the unit? The API should return EDG for Edgeware
| * Returns the currency on basis of the selected protocol in Mailchain | ||
| * @param protocol the cureent protocol | ||
| */ | ||
| getCurrencyForProtocol(protocol: string) { |
There was a problem hiding this comment.
Is it better for the API to return the currency based on the protocol and network? (e.g. wei for current Ethereum supported networks, edg for Edgeware-mainnnet, algo for Algorand)
This reduces the amount of logic required in the front end, although some is still require for UX, for example a wei to eth conversion for Ethereum.
| "type": 4, | ||
| "body": { | ||
| "balance": 218, | ||
| "unit": "ALGO" |
There was a problem hiding this comment.
Can you also check the case of the server response?
| <br /> | ||
| <!-- ./Show Balance Label --> | ||
| <!-- Show Fees Label --> | ||
| <!-- <div class="form-group row mb-0"> |
There was a problem hiding this comment.
Please can you remove this until it's implemented?
|
Thanks for sharing , I am working on the changes . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you please review the code for Balance Functionality from the FE perspective?