Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network ids to /protocols endpoint #281

Closed
tboeckmann opened this issue Sep 24, 2019 · 2 comments
Closed

Add network ids to /protocols endpoint #281

tboeckmann opened this issue Sep 24, 2019 · 2 comments
Labels
enhancement New feature or request protocol/substrate

Comments

@tboeckmann
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In order to support substrate, the /protocols endpoint should return network ID with the network name in the response for each protocol.

Describe the solution you'd like
Upgrade the existing response to include the name & id fields as strings. Empty id values should be returned as empty strings.

E.g.:

[
  {
    "name": "string",
    "networks": [
      // "string"    <-- previous value
      { "name": "string", "id": "string" }
    ]
  }
]

Describe alternatives you've considered

Additional context

@tboeckmann
Copy link
Contributor Author

See here for reference to Network IDs in substrate:
paritytech/substrate@cf98501#diff-a40465c5924214464e991fe6c9deb541R327
&
paritytech/substrate#3147

@robdefeo
Copy link
Member

closed by #401

tboeckmann added a commit to mailchain/mailchain-web that referenced this issue Nov 30, 2019
@robdefeo robdefeo added this to Done in protocol/substrate Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request protocol/substrate
Projects
Development

No branches or pull requests

2 participants