This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
SS58 versioning (Network IDs) #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doesn't need to be merged with the commented code, but should be reviewed and okayed on the proviso that it'll be merged with the commented code uncommented or otherwise removed. |
gavofyork
added
A8-looksgood
and removed
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the ability to customise which version code is used for SS58 via a network configuration.
It will still default to 42 (Substrate generic version) within Substrate and Node, but Polkadot can now switch it to use Polkadot (0) or Kusama (2). Subkey has been changed to allow it to be configured on the CLI with the
--networkoption.