Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@gm, @gma and @gmai are suggested as @gr #129

Closed
pke opened this issue May 17, 2016 · 2 comments · Fixed by #138
Closed

@gm, @gma and @gmai are suggested as @gr #129

pke opened this issue May 17, 2016 · 2 comments · Fixed by #138

Comments

@pke
Copy link

pke commented May 17, 2016

Using the default options any input of

name@gm
name@gma
name@gmai

is suggested with domain gr. Any idea why?
@caphun
Copy link
Contributor

caphun commented Oct 13, 2016

any update on this issue?

@caphun caphun mentioned this issue Oct 14, 2016
Merged
@pke
Copy link
Author

pke commented Oct 14, 2016

@caphun nope. No idea whats going on. Maybe if #133 would be merged, the problem would go away. Or by removing the .gr domain.

caphun added a commit to tofugear/mailcheck that referenced this issue Oct 16, 2016
@caphun
added tests for mailcheck#129 fix. removed gmx.de from the spec since…
49ecc80 
… it is not one of the defaultDomains in the Mailcheck plugin and hence will cause test discrepancies during test runs
caphun added a commit to tofugear/mailcheck that referenced this issue Dec 7, 2016
@caphun
added tests for mailcheck#129 fix. removed gmx.de from the spec since…
1e6ec38 
… it is not one of the defaultDomains in the Mailcheck plugin and hence will cause test discrepancies during test runs
derrickko added a commit that referenced this issue Dec 7, 2016
@derrickko
Merge pull request #138 from tofugear/master
24149b1 
fixes issue #129: only check tld if sld exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes issue #129: only check tld if sld exists tofugear/mailcheck
2 participants
@caphun @pke