Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to serve attachments #2

Closed
wants to merge 5 commits into from
Closed

add ability to serve attachments #2

wants to merge 5 commits into from

Conversation

paschdan
Copy link
Contributor

No description provided.

paschdan added 4 commits November 22, 2013 21:15
…ration you used to have not so many differences. you have to build the css file yourself to have the line comment
@djfarrelly
Copy link
Member

Will take a look at this when I get back home tomorrow.

add debug messages for fs-functions
remove unessesary debug message
@djfarrelly
Copy link
Member

Creating a temp directory for attachments within the package's folder won't work when installed globally since the package doesn't have root access. The os's temp folders need to be used for this to work. This can be achieved using something like https://github.com/raszi/node-tmp or https://github.com/vesln/temporary.

I'm going to take a crack at using one of these libraries to create the temp folder & files tomorrow.

@djfarrelly
Copy link
Member

Decided to just use node's os.tmpdir() method and most of your logic to create a temp system directory instead of use either one of those packages. I'm going to publish this to NPM tonight as v.0.4.0. Thanks for the help @paschdan!

Let me know if you have any other ideas/requests for the project.

@djfarrelly djfarrelly closed this Dec 2, 2013
djfarrelly added a commit that referenced this pull request May 11, 2017
DominikSerafin added a commit that referenced this pull request Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants