Rebase branch for upstream changes through 1.0.2 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client: refactor tests
client: redesigned response handling
Replace various update channels with one unique channel
scanner.Scan returns false but scanner.Err returns nil in case of EOF.
Now only the 'current' parameter is modified. The same update operation can be applied to multipe flag lists (i.e. multiple messages). Applying the same UpdateFlags operation on multiple messages wasn't safe, since the 'flags' (last parameter) was modified. The 'SetFlags' operation wass returning 'flags' parameter. Multiple messages would have been sharing the same slice's backing store. Future changes to one message's flags wouldd corrupt the other messages flags. The 'RemoveFlags' operation was modifying the 'flags' parameter contents (but not length). So it wasn't safe to apply to multiple messages.
Some commands use a channel to stream results from the backend. If the client connection closes before all of the results have been written, then a deadlock can happen.
This allows for easy access to the body structure's filename, if any. Charset decoding and legacy Content-Type support are handled.
This is a helper to iterate over a body structure tree. Closes: emersion#319
KEYWORD and UNKEYWORD should be followed by an atom, not a quoted string.
Signed-off-by: Arnold Bechtoldt <arnold.bechtoldt@inovex.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates us to the latest upstream changes plus our changes.