Make fallback from MongoDB to in-memory storage configurable #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickeasters
force-pushed
the
mongo_fallback
branch
from
e49fb9e
to
b13e215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run Mailhog instances in preprod environments where we run a single replica along with a single Mongo container in Kubernetes/Openshift. When spinning up a new instance of Mailhog, the database is not always ready when Mailhog starts.
This PR allows Mailhog to crash if it's unable to connect to Mongo instead of falling back to in-memory storage. This is desirable for us since Kubernetes will back-off/retry until the database is ready.