Add ReadCloser method to jwriter and buffer #77
Conversation
|
@vstarodub and input on this? We have been using this in productions for a while now so we know the code is stable and works. |
|
@vstarodub need any help maintaining this repo? |
|
Is this repo still maintained? |
|
@vstarodub any update on if this will ever get merged? If not, what is the reason? |
buffer/pool.go
Outdated
|
|
||
| // ReadCloser creates an io.ReadCloser with all the contents of the buffer. | ||
| func (b *Buffer) ReadCloser() io.ReadCloser { | ||
| println(len(b.bufs) + 1) |
There was a problem hiding this comment.
remove debug logging please
There was a problem hiding this comment.
Ouch that's stupid :(
buffer/pool.go
Outdated
| } | ||
| } | ||
| // No buffers left or nothing read? | ||
| if len(r.bufs) == 0 || n == 0 { |
There was a problem hiding this comment.
Should this really be io.EOF when caller passed p with len(p) == 0?
Implementations of Read are discouraged from returning a zero byte count with a nil error, except when len(p) == 0. Callers should treat a return of 0 and nil as indicating that nothing happened; in particular it does not indicate EOF.
There was a problem hiding this comment.
Also, net.Buffers from go 1.8 behaviour in Read() method: https://beta.golang.org/src/net/net.go?#L672
There was a problem hiding this comment.
Yes, if you don't return io.EOF most readers will never stop waiting for additional data. The net.Buffers example you link to returns io.EOF as well. Functions like bytes.Buffer.ReadFrom only break on io.EOF.
There was a problem hiding this comment.
Yes, you are right. But I mean the second check in that if:
Is n == 0 really the same as len(r.bufs) == 0?
I mean, what will change, if we remove the check of n == 0?
There was a problem hiding this comment.
Yes I guess it only makes sense when there is an empty buffer in r.bufs, which will never happen.
erikdubbelboer
force-pushed
the
readcloser
branch
from
24d7e3e
to
bfe82a8
Compare
When marshalling something as body for a http.Request we can only use BuildBytes() which always allocates a buffer for our whole body. This pull request adds a ReadCloser() method which returns an io.ReadCloser that can be passed as body into http.NewRequest. This ReadCloser will read from the existing buffs and putBuf them when they are not needed anymore.
erikdubbelboer
force-pushed
the
readcloser
branch
from
bfe82a8
to
ce0e787
Compare
|
Thanks! 🍻 |
|
Thank you. |
When marshalling something as body for a
http.Requestwe can only useBuildBytes()which always allocates a buffer for our whole body. Thispull request adds a
ReadCloser()method which returns anio.ReadCloserthat can be passed as body into
http.NewRequest. ThisReadCloserwillread from the existing buffs and
putBufthem when they are not neededanymore.