Create Auth Pages #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mailsg
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Hi @forLoop94 ,
Status: Approved ✔️ ✔️ ✔️
To Highlight 💪🏻
- Sign up authentication is working as expected✔️
- User can login with the sign up credentials✔️
- Bearer token is generated and well captured in local storage for the session✔️
- At log out the token is destroyed and removed successfully from the local storage.✔️
Good job implementing the requirements
Congratulations! 🎉
Optional Suggestions :
- N/A
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag ichala in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes were made:
Create Sign up component and provide logic that creates a user account and saves the bearer token in local storage
Create Log in component and provide logic to log in as a registered user and save the bearer token in local storage
Create a button to sign out the logged_in user and delete the session token from the local storage