Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end integration testing #23

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Front-end integration testing #23

merged 1 commit into from
Oct 12, 2023

Conversation

mailsg
Copy link
Owner

@mailsg mailsg commented Oct 12, 2023

Hi,

This PR is raised to write the integration tests as well as unit testing for the react components.

Kindly review the PR and provide feedback on the same.

Thanks.

@mailsg mailsg linked an issue Oct 12, 2023 that may be closed by this pull request
@mailsg mailsg requested a review from forLoop94 October 12, 2023 05:24
Copy link
Collaborator

@forLoop94 forLoop94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mailsg 👋,

Your task is complete! There is nothing else to say other than... it's time to merge it.
Congratulations! 🎉 🥳🥇

Highlights

  • Mobile menu looks great ✔
  • All linter checks are passing ✔

Optional suggestions

  • N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@mailsg mailsg merged commit 9dc1bbf into development Oct 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3 Pts.] Add Front-end integration testing
2 participants