Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails Blog App - Create data model #1

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

mailsg
Copy link
Owner

@mailsg mailsg commented Aug 22, 2023

Hi,

This PR is raised to showcase the demonstration of a Rails App's M - Model part of the MVC architecture. Below are the pointers covered :

  • Created a new app with a meaningful name.
  • Initialized project with Git.
  • Made sure that the project has Postgres database set up.
  • Built project schema.
    • Created and run the necessary migration files.
    • Table and column names matches the ERD diagram.
    • Foreign keys should be included.
      • In posts table the column holding the foreign key to the users table is named author_id
    • All columns that are foreign keys should have a corresponding index.

Kindly review the PR and provide feedback on the same.

Thanks.

Copy link

@ichala ichala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Student ,

Status: Approved ✔️ ✔️ ✔️

68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f6c3366516333614356304871707a5763552f67697068792e676966

To Highlight 💪🏻

  • Database adapter is using Postgresql✔️
  • Followed the ERD diagram✔️
  • Used rails migration✔️

Good job implementing the requirements 👍 Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Optional Suggestions :

  • N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag ichala in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@mailsg mailsg merged commit b266d76 into development Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants