Rails Blog App - Validations and model specs #3
Conversation
There was a problem hiding this comment.
Hi @mailsg ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Added validations and model specs✔️
- Well Structured Code ✔️
- Used Git flow ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| @@ -115,7 +115,7 @@ To run the project, execute the following command: | |||
| To run tests, run the following command: | |||
|
|
|||
| ```sh | |||
| bin/rails test test/models/article_test.rb | |||
| rspec | |||
There was a problem hiding this comment.
- Kindly, your
mitlink is broken please update it to have a professional readme file 👍
There was a problem hiding this comment.
Hi @mailsg ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- Added validations and model specs✔️
- Well Structured Code ✔️
- Used Git flow ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi,
This PR is raised to showcase the implementation of Validations and model specs. Below are the pointers covered in the implementation:
Added the following validations:
For the
User model:PostsCountermust be an integer greater than or equal to zero.For the
Post model:CommentsCountermust be an integer greater than or equal to zero.LikesCountermust be an integer greater than or equal to zero.Added unit specs for all the models' methods and validations.
Kindly review the PR and provide feedback on the same.
Thanks.