Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version check in admin #43

Closed
adampresley opened this issue Mar 18, 2016 · 3 comments
Closed

Version check in admin #43

adampresley opened this issue Mar 18, 2016 · 3 comments
Assignees
Milestone

Comments

@adampresley
Copy link
Contributor

Add the ability for MailSlurper to lookup the current version information from the master branch in Github and display an alert box on the admin screen if the version of MailSlurper being run is behind.

@adampresley adampresley added this to the Release 1.12 milestone Mar 18, 2016
@markhorrocks
Copy link

Hi Adam,
This would be good for us if we could view an html email in a new tab on chrome. Any chance? Best,
Mark Horrocks email: markhorrocks@yahoo.com

  From: Adam Presley <notifications@github.com>

To: mailslurper/mailslurper mailslurper@noreply.github.com
Sent: Friday, 18 March 2016, 20:57
Subject: [mailslurper] Version check in admin (#43)

Add the ability for MailSlurper to lookup the current version information from the master branch in Github and display an alert box on the admin screen if the version of MailSlurper being run is behind.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

@adampresley
Copy link
Contributor Author

Hi @markhorrocks. This sounds like something that can certainly be done. I've made a new ticket for this, #44. How do you see this working? A button on the preview pane that opens in a new tab? Please comment over on issue #44. Thanks!

@markhorrocks
Copy link

Hi Adam,
Yes, that would be how I see it working. It needs to open in a separate browser so the emails can be tested on various platforms. Basically, what you have now allows us to test the email selection and sending functionality of the app but we also want to check that the emails themselves look correct as they are built by the app. A built in viewer wouldn't be the solution I believe.
cheers, Mark Horrocks email: markhorrocks@yahoo.com

  From: Adam Presley <notifications@github.com>

To: mailslurper/mailslurper mailslurper@noreply.github.com
Cc: Mark Horrocks markhorrocks@yahoo.com
Sent: Thursday, 24 March 2016, 9:01
Subject: Re: [mailslurper] Version check in admin (#43)

Hi @markhorrocks. This sounds like something that can certainly be done. I've made a new ticket for this, #44. How do you see this working? A button on the preview pane that opens in a new tab? Please comment over on issue #44. Thanks!—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants