Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #206 fix ember-polyfills.deprecate-merge deprecation #210

Closed
wants to merge 1 commit into from

Conversation

habdelra
Copy link

@habdelra habdelra commented Mar 1, 2019

Fixes the deprecation:

DEPRECATION: Use of `merge` has been deprecated. Please use `assign` instead. [deprecation id: ember-polyfills.deprecate-merge] See https://emberjs.com/deprecations/v3.x/#toc_ember-polyfills-deprecate-merge for more details.

Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still supporting Ember < 2.0 actually (see https://github.com/simplabs/ember-cookies/blob/master/config/ember-try.js) which means we'd have to add https://github.com/shipshapecode/ember-assign-polyfill to not make this a breaking change.

@Turbo87
Copy link
Collaborator

Turbo87 commented Mar 7, 2019

@habdelra in what situation did you hit that deprecation? we are defaulting to using Object.assign() or the non-deprecated Ember.assign() so I'm wondering what caused that deprecation message for you 🤔

@habdelra
Copy link
Author

habdelra commented Mar 7, 2019

It's actually neither Object.assign nor Ember.assign polyfill. It is the Ember.merge polyfill that is deprecated in 3.7. and it looks like just importing it was triggering the deprecation message.

@habdelra
Copy link
Author

habdelra commented Mar 7, 2019

Specifically it fixes this issue: #206

@marcoow
Copy link
Member

marcoow commented Mar 8, 2019

Looking at the source, the deprecation should only be triggered once merge is actually invoked. I also couldn't see it when running the demo app or the tests 🤔

@marcoow
Copy link
Member

marcoow commented Mar 8, 2019

I believe this was fixed by #204 already actually - I'll release a new version including that.

@marcoow marcoow closed this Mar 8, 2019
@habdelra
Copy link
Author

habdelra commented Mar 8, 2019

Could you also rev ember-simple-auth with the new ember-cookies to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants