Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for files with class properties #94

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Add support for files with class properties #94

merged 1 commit into from
Nov 25, 2019

Conversation

jmonster
Copy link
Contributor

closes #64

@Turbo87
Copy link
Collaborator

Turbo87 commented Nov 15, 2019

thanks @jmonster!

can you add a test case for this so that we don't regress on this issue? 🙏

@Turbo87 Turbo87 added the enhancement New feature or request label Nov 15, 2019
@jmonster
Copy link
Contributor Author

@Turbo87 I don't mean to neglect this PR but I had a difficult time coming up with a simple way to test this change. Could you offer any guidance for how you imagine this property being tested?

I attempted to simply use the new class syntax in a test but I believe it passed with and without the change from this PR 🤷‍♂

@Turbo87
Copy link
Collaborator

Turbo87 commented Nov 25, 2019

I attempted to simply use the new class syntax in a test but I believe it passed with and without the change from this PR

that would have been my idea. seems surprising that it doesn't work. do you have any idea why it works without the change?

@jmonster
Copy link
Contributor Author

@Turbo87 I updated this PR to have a test, but note as long as the file contains this.intl.t('js-translation'); -- even if I precede it with throw new Error("anything") or return false -- the tests pass. Removing that line, however, yields test failures.

Adding classProperties (the original change in this PR) has no effect on these tests passing/failing

Any advice how to proceed?

@Turbo87 Turbo87 changed the title Add support for experimental classProperties Babel plugin Add support for files with class properties Nov 25, 2019
@Turbo87 Turbo87 merged commit 171604a into mainmatter:master Nov 25, 2019
@jmonster jmonster deleted the class-properties branch November 25, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for experimental classProperties Babel plugin
2 participants