Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix promise-modals from breaking when used in another addon instead of an app #422

Merged
merged 1 commit into from
Jul 27, 2021
Merged

fix promise-modals from breaking when used in another addon instead of an app #422

merged 1 commit into from
Jul 27, 2021

Conversation

nickschot
Copy link
Member

@nickschot nickschot commented Jul 27, 2021 •
edited
Loading

No description provided.

@nickschot nickschot requested a review from a team July 27, 2021 15:15
@nickschot nickschot added the bug Something isn't working label Jul 27, 2021
@nickschot nickschot changed the title fix promsie-modals from breaking when used in another addon instead o… fix promsie-modals from breaking when used in another addon instead of an app Jul 27, 2021
mansona
mansona approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 good catch

@nickschot nickschot merged commit 7ee6613 into master Jul 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-project-ref branch July 27, 2021 15:24
@nickschot nickschot changed the title fix promsie-modals from breaking when used in another addon instead of an app fix promise-modals from breaking when used in another addon instead of an app Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickschot @mansona