Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-getowner-polyfill is depracated #1159

Closed
rhadoo200 opened this issue Jan 2, 2017 · 4 comments
Closed

ember-getowner-polyfill is depracated #1159

rhadoo200 opened this issue Jan 2, 2017 · 4 comments

Comments

@rhadoo200
Copy link

Hi,
Ember cli is giving me this notification:

DEPRECATION: ember-getowner-polyfill is now a true polyfill. Use Ember.getOwner directly instead of importing from ember-getowner-polyfill [deprecation id: ember-getowner-polyfill.import]

Could you please remove the import of ember-getowner-polyfill and replace it with the given function? I've noticed that in every file where the module is imported you are importing some constants objects from ember. Please add also getOwner in that list of constants.

Thanks,
Radu

@marcoow
Copy link
Member

marcoow commented Jan 3, 2017

This is fixed with #1124 already.

@rhadoo200
Copy link
Author

If I install the package with just npm install it will install the project with the old import lines.
When I specify a commit ID then the latest sources are installed. The npm repository is up to date with this fix?

@marcoow
Copy link
Member

marcoow commented Jan 3, 2017

This has not been released yet.

@rhadoo200
Copy link
Author

ok thanks. i will stick to a commit id then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants