Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations related to deprecate util #2335

Closed
wants to merge 3 commits into from
Closed

Fix deprecations related to deprecate util #2335

wants to merge 3 commits into from

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Oct 30, 2021

Fixes the new deprecations introduced in #2318.

@bertdeblock bertdeblock changed the title Fix deprecations related to deprecation util Fix deprecations related to deprecate util Nov 3, 2021
Copy link
Collaborator

@BobrImperator BobrImperator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :)

@bertdeblock
Copy link
Contributor Author

Can we merge and release this? I'd like to get rid of these deprecations in our app.

@lougreenwood
Copy link

lougreenwood commented Dec 7, 2021

Can we get this or one of the other 2 PRs which fix this merged please:

#2335
#2347

@BobrImperator BobrImperator linked an issue Dec 9, 2021 that may be closed by this pull request
@BobrImperator
Copy link
Collaborator

Sorry for the delay on this 🥲

@bertdeblock do you think we still need the changes?
Is there any advantage to having the since.available property defined?

@bertdeblock
Copy link
Contributor Author

TBH, I'm not super familiar with the deprecation staging RFC and how it should be applied within addons. I'm guessing the deprecation warnings are gone now?

@BobrImperator
Copy link
Collaborator

BobrImperator commented Dec 9, 2021

I think they are gone and probably the available property is not needed anymore.
Should we close this?

@bertdeblock bertdeblock closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation: old-deprecate-method-paths
4 participants