Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Object.assign and drop Ember.assign #2542

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

RobbieTheWagner
Copy link
Contributor

No description provided.

@derrabauke
Copy link

Hey folks, any ambitions to release this soon? :-)

@BobrImperator
Copy link
Collaborator

Hi @derrabauke

Yes, however I'm vacationing at the moment and there's some manual checks I need to run before releasing.

Especially need to verify if our test-apps are failing on ember-beta and ember-canary channels due to fastboot/ember-data issues or there are problems with the library.

for context:

#2411 (comment)
#2550

@jrjohnson
Copy link

Enjoy your vacation @BobrImperator! When you return (and not a moment sooner) I'm happy to test a beta release in our app or anything else I can do to be helpful pre-release.

@derrabauke
Copy link

Hi @derrabauke

Yes, however I'm vacationing at the moment and there's some manual checks I need to run before releasing.

Especially need to verify if our test-apps are failing on ember-beta and ember-canary channels due to fastboot/ember-data issues or there are problems with the library.

for context:

#2411 (comment) #2550

Thanks for the information and enjoy your holidays! 👍

@BobrImperator
Copy link
Collaborator

BobrImperator commented May 10, 2023

Hi folks, I've just released a 6.0.0-rc.1 version of ESA.

The reason why it's an RC version is that at this very moment ember-canary, ember-beta channels fail due to some ember-source issues in these versions.

Also our tests rely on Fastboot which fails for ember-data >= 4.12 versions 🤷
Because of that I can't be confident that everything works correctly. I have tested things manually without Fastboot and it seems things are working.

So unless you're using Fastboot it seems like everything should work, but until I've confirmed what's going on you'll need to use the rc.1 version for the time being. If you're blocked by 5.0.0 then use that.

I'm sorry for the inconvenience, I'll try to sort that out as soon as possible.

Changes made are here https://github.com/mainmatter/ember-simple-auth/blob/master/CHANGELOG.md

@jrjohnson
Copy link

Initial testing is looking good for us. We had a small problem with embroider, but updating to the latest version of all embroider libs fixed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants