MAISTRA-2437: Push configuration as String #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct.
|
This is the same as #381 but targeted for 1.9 |
rcernich
approved these changes
Jul 6, 2021
brian-avery
approved these changes
Jul 6, 2021
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 2, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 4, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 4, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 7, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 9, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 21, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 22, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Feb 28, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
luksa
pushed a commit
to luksa/istio-maistra
that referenced
this pull request
Mar 1, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
maistra-bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
* MAISTRA-2437: Push configuration as String Envoy doesn't handle well passing a Struct as the configuration field. When an extension retrieves its value, it gets binary data. Passing string instead is safe. Extensions will get the value as string and can unmarshal it into a proper JSON struct. * Fix an potential index out of range error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envoy doesn't handle well passing a Struct as the configuration field.
When an extension retrieves its value, it gets binary data.
Passing string instead is safe. Extensions will get the value as string
and can unmarshal it into a proper JSON struct.
While on it, also fixed a potential
index out of rangeerror.