Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAISTRA-1744] Route Annotations Documentation Update #158

Merged
merged 4 commits into from Aug 12, 2020

Conversation

David-Elizondo
Copy link

@David-Elizondo David-Elizondo commented Aug 12, 2020

Adding documentation in reference to propagating route annotations in IOR. Feature will be added from these PRs:

Version 1.1: maistra/ior#11
Version 2.0: maistra/istio#158

https://issues.redhat.com/browse/MAISTRA-1744

@maistra-bot
Copy link

Hi @rtselizondo. Thanks for your PR.

I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brian-avery
Copy link
Contributor

/retest

@brian-avery
Copy link
Contributor

That failure is being fixed in #161.

@brian-avery
Copy link
Contributor

/retest

@maistra-bot
Copy link

@rtselizondo: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brian-avery
Copy link
Contributor

/retest

@mergify mergify bot merged commit ade0992 into maistra:maistra-2.0 Aug 12, 2020
@brian-avery
Copy link
Contributor

/cherry-pick maistra-1.1

@maistra-bot
Copy link

@brian-avery: new pull request created: #162

In response to this:

/cherry-pick maistra-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants