Fix issues preventing the use of Bolt v5 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing lib/src/messages.c with <https://neo4j.com/docs/bolt/current/bolt/message/#messages-summary>, it seems that this set of supported versions is a more accurate description of what is actually implemented. In particular, the messages LOGON and LOGOFF appear to be unavailable, so Bolt version 5.1 and newer will cause problems. According to <https://neo4j.com/docs/bolt/current/bolt-compatibility/>, Bolt versions 5.0 and 4.0 enjoy full support by the current community server versions (Neo4j 5.16 / 4.4).
Trying to read actual element IDs received over Bolt v5 caused assertion failures in neo4j_node_elementid() and friends. According to the Bolt v5 protocol structure semantics, element IDs are transferred as strings. Because struct_deserialize() left them as NEO4J_STRING, reading out the element IDs failed as other code expects them to be NEO4J_ELEMENTID. The issue doesn't show up on earlier Bolt versions because for those versions, the element IDs are synthesized from legacy numeric IDs during deserialisation. That special case uses the correct neo4j_value type NEO4J_ELEMENTID to begin with. This change replaces the NEO4J_STRING neo4j_value type metadata of received element ID strings with NEO4J_ELEMENTID. The underlying string is not touched.
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@majensen
Addresses majensen/perlbolt#54.
Resolves #3. (I did not, however, look into the segfault related to mangled failure codes.)