Sequential check of the data before seeding #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mutex is used to ensure that the integrity of each torrent is checked one after the other (sequential check) instead of concurrently, before seeding. This makes the check about six times faster (at least on spinning hard disks).
majestrate
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mutex is added in fsTorrent.VerifyAll to ensure that the integrity of each torrent is checked one after the other (sequential check) instead of concurrently, before seeding. This makes the check about six times faster (at least on my setup with a spinning hard disk, ~5 minutes instead of ~30 minutes).
Note: The test for configparser fails with 'exec: "shasum": executable file not found in $PATH' on my system because there is no shasum on OpenBSD apparently, but I didn't touch configparser, so it should be good.