Skip to content

Commit

Permalink
Fix message for #164 issue
Browse files Browse the repository at this point in the history
  • Loading branch information
jmrenouard committed Mar 24, 2016
1 parent 84d108b commit 10a5ad0
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions mysqltuner.pl
Original file line number Diff line number Diff line change
Expand Up @@ -961,24 +961,13 @@ sub system_recommendations {
my @opened_ports=get_opened_ports;
infoprint "There is ". scalar @opened_ports. " listening port(s) on this server.";
if (scalar(@opened_ports) > $opt{'maxportallowed'}) {
badprint "There is too many listening ports: ". scalar(@opened_ports). " > 10";
badprint "There is too many listening ports: ". scalar(@opened_ports) " opened > ".$opt{'maxportallowed'}. "allowed.";

This comment has been minimized.

Copy link
@dvdknaap

dvdknaap Mar 24, 2016

Contributor

Use this to correct it
badprint "There is too many listening ports: ". scalar(@opened_ports)." opened > ".$opt{'maxportallowed'}. "allowed.";

push( @generalrec, "Consider dedicating a server for your database installation with less services running on !" );
} else {
goodprint "There is less than ".$opt{'maxportallowed'}." opened ports on this server.";
}
}
# if ( is_open_port(80) or is_open_port(443) ) {
# badprint "There is Apache like server running on 80 or 443 port.";
# push( @generalrec, "Consider dedicating a server for Web server in production !" );
# } else {
# goodprint "No Web server runing on 80 and 443 port.";
# }
# if ( is_open_port(8080) or is_open_port(8443) ) {
# badprint "There is Application server running on 8080 or 8443 port.";
# push( @generalrec, "Consider dedicating a server for Application server in production !" );
# } else {
# goodprint "No Application server runing on 8080 or 8443 port.";
# }

foreach my $banport (@banned_ports) {
if ( is_open_port($banport) ) {
badprint "Banned port: $banport is opened..";
Expand Down

1 comment on commit 10a5ad0

@netsandbox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String found where operator expected at /usr/local/sbin/mysqltuner.pl line 964,
near ") " opened > "" (#1)

Please sign in to comment.