Skip to content

Commit

Permalink
correct messages on no InnoDB
Browse files Browse the repository at this point in the history
enginestats are only populated if tables exist of that type.

Look at default_storage_engine if defined to communicate the default
storage engine.

closes #469
  • Loading branch information
grooverdan committed Feb 1, 2021
1 parent 950df57 commit 5c307d1
Showing 1 changed file with 14 additions and 7 deletions.
21 changes: 14 additions & 7 deletions mysqltuner.pl
Original file line number Diff line number Diff line change
Expand Up @@ -5557,21 +5557,28 @@ sub mysql_innodb {

# InnoDB
unless ( defined $myvar{'have_innodb'}
&& $myvar{'have_innodb'} eq "YES"
&& defined $enginestats{'InnoDB'} )
&& $myvar{'have_innodb'} eq "YES")
{
if ( $opt{skipsize} eq 1 ) {
infoprint "Skipped due to --skipsize option";
return;
}
infoprint "InnoDB is disabled.";
if ( mysql_version_ge( 5, 5 ) ) {
my $defengine = 'InnoDB';
$defengine = $myvar{'default_storage_engine'} if defined($myvar{'default_storage_engine'});
badprint
"InnoDB Storage engine is disabled. InnoDB is the default storage engine";
"InnoDB Storage engine is disabled. $defengine is the default storage engine" if $defengine eq 'InnoDB';
infoprint
"InnoDB Storage engine is disabled. $defengine is the default storage engine" if $defengine ne 'InnoDB';
}
return;
}
infoprint "InnoDB is enabled.";
if (! defined $enginestats{'InnoDB'} ) {
if ( $opt{skipsize} eq 1 ) {
infoprint "Skipped due to --skipsize option";
return;
}
badprint "No tables are Innodb";
$enginestats{'InnoDB'} = 0;
}

if ( $opt{buffers} ne 0 ) {
infoprint "InnoDB Buffers";
Expand Down

0 comments on commit 5c307d1

Please sign in to comment.