Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MySQL version check subroutine (issue #7) #14

Closed
wants to merge 3 commits into from
Closed

Fix for MySQL version check subroutine (issue #7) #14

wants to merge 3 commits into from

Conversation

arruor
Copy link

@arruor arruor commented Dec 30, 2011

Adopting scop's idea for more reliable version recognition, both for local and remote servers.

Version check should work as follows:

  • assuming that 32-bit version of MySQL is used by default
  • check if 'version_compile_machine' ends with string '64' - if yes, then change version to 64-bit (on non-Windows OS)
  • check if 'version_compile_os' ends with string '64' - if yes, then change version to 64-bit (on Windows OS)
  • in all other cases MySQL version should be 32-bit

Adopting scop's idea to write more reliable verification
of MySQL's architecture version, both for local and remote servers.
Adopting scop's idea for MySQL version check. Now should work as discussed, both for local and remote servers.
@major
Copy link
Owner

major commented Feb 22, 2014

Sorry for the long delay in reviewing this PR. If you can update your patch to match trunk, I'll gladly merge it.

@major major closed this Feb 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants