Fix for MySQL version check subroutine (issue #7) #14

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@arruor
arruor commented Dec 30, 2011

Adopting scop's idea for more reliable version recognition, both for local and remote servers.

Version check should work as follows:

  • assuming that 32-bit version of MySQL is used by default
  • check if 'version_compile_machine' ends with string '64' - if yes, then change version to 64-bit (on non-Windows OS)
  • check if 'version_compile_os' ends with string '64' - if yes, then change version to 64-bit (on Windows OS)
  • in all other cases MySQL version should be 32-bit
arruor added some commits Dec 28, 2011
@arruor arruor Fixing issue with unused variable in check_architecture subroutine. M…
…ore info available at: major#7
965745d
@arruor arruor New fix for issue#7 about MySQL version reckognition
Adopting scop's idea to write more reliable verification
of MySQL's architecture version, both for local and remote servers.
f75e9d0
@arruor arruor Fix for issue #7 about more reliable MySQL version reckognition.
Adopting scop's idea for MySQL version check. Now should work as discussed, both for local and remote servers.
77d2398
Owner
major commented Feb 22, 2014

Sorry for the long delay in reviewing this PR. If you can update your patch to match trunk, I'll gladly merge it.

@major major closed this Feb 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment