-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request code review for weather app #2
Conversation
…etween F and C degrees
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stellar work!
Really impressed by this.
But... there is one requirement missing:
- The application makes different requests for the Celsius data and the Fahrenheit data (The student could get the data for either unit and use math to convert it to the other unit. That beats the point of the assignment) (screenshot from Pathwright)
Status: Request changes.
Optional: All comments on the code are just for your consideration, not changes required on those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flawless execution!
Status: Approved.
Optional 🤣: Just to be annoying, some more comments! But they are not required 😅.
Love the cache you are implementing, but there must be something I am not getting. When I do the same request, it is not loading the data stored on localStorage
, it always makes new requests for previously stored data instead of getting it from localStorage
. Is that the expected behavior?
Ok so I found what the problem was (with the help of my coding partner) It turns out I was creating a variable with the API call at the beginning of the function, therefore it was always executing it. So I just moved it and it's working!! Thanks for your amazing feedback!! I really liked how it made me improve the app 😄 |
This Pull Request includes:
I would appreciate your help with the linter error that I'm getting. I don't understand how to use destructuring in that case
Thanks for your review!