add option for statusline overwriting

[bling]

this would be the easiest route for fixing vim-airline/vim-airline#105. thanks.

[jchain]

I'm curious. It seems that vim-airline already supports tagbar. Why does this patch still make sense?

[majutsushi]

I had actually implemented a customisable statusline function similar to what ctrlp does some time ago as an experiment for PowerLine, but since the author didn't have enough time to have a look at it and test it out I haven't merged it yet. I can check whether it still works and push it to a branch if you would like to try it out. That would make it possible to display more information in the Tagbar statusline, like the current sort order.

[bling]

@jchain this patch is specifically for detecting active window splits. tagbar (and a lot of plugins) use eventignore to change windows, so none of the autocmds that airline depends on get fired. i could go into more details but basically to resolve vim-airline/vim-airline#105 it would involve either this patch, a change to the core of tagbar, or a very hacky polling of the statusline value for changes in airline.

[majutsushi]

By the way, the eventignore is necessary to prevent other plugins like MiniBufExplorer from interfering with window switching, see for example #17 and #56 .

[bling]

@majutsushi yep, understood. btw, is there something you don't like about this change?

[majutsushi]

Not as such, I just think it would be a bit more useful if the
statusline information wouldn't get lost by overwriting it. In addition
it may be possible to make the CursorMoved autocommand unnecessary (at
least for Tagbar), but I'll have to investigate that a bit more.

[bling]

i just added the use of TagbarGenerateStatusline, so no information should be lost anymore. let me know if you need anything else from me. thanks!

[qva5on3]

It looks like #165 relates to this issue.

@bling @majutsushi What is currently the best solution for this problem. Should I use bling/vim-airline#105 as workaround. Thanks.

[bling]

@qva5on3 for the original issue in airline, it's been "fixed" since i've resorted to the hack fix. the performance cost is negligible so i included it. if this patch gets merged or if @majutsushi comes up with another solution i'll remove the change from airline.

[majutsushi]

Hi @bling, I have just pushed some experimental changes to the stltest branch. I have disabled the window switching autocommand ignores (since MiniBufExplorer seems to have been fixed), and added proper flexible statusline functionality like CtrlP.

To use the new statusline assign a function name to g:tagbar_status_func. The function takes three arguments: whether Tagbar is the current window (0 or 1), the sort order as a String, and the filename being displayed (may be empty if no file has been loaded yet). Please let me know if that works for you and if you have any suggestions for improvements!

[bling]

thanks @majutsushi! this is much cleaner. i did some basic tests and it appears to be working. i need some extra work on my side to account for the inactive state, but that was on my todo list anyways so this is a good catalyst. please close off this PR when you feel your changes are good and merged into master. thanks again.

[majutsushi]

Okay, I've merged the code now. Note that it may be useful to define the statusline function with an additional vararg just so it doesn't break if there's a need to add more arguments in the future.

[bling]

thanks @majutsushi! changes are in on my end as well.

[majutsushi]

Nice, it seems to work great!