Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#186452718] Add new hints to 'Did you know' #205

Merged

Conversation

steevokovsky-mkd
Copy link
Contributor

No description provided.

@steevokovsky-mkd
Copy link
Contributor Author

steevokovsky-mkd commented Nov 14, 2023

You suggessted the hint for shelll.rb to be:

  • 'You only need to type the unique prefix of a command to run it. geordi rs will work as well.'

I changed that to:

  • 'You only need to type the unique prefix of a command to run it. geordi sh will work as well.'

Also, the rspec command only printed a hint when not using parallel_tests, I moved the code down to run it outside this if/else.

Is that correct?

@codener
Copy link
Member

codener commented Nov 16, 2023

You suggessted the hint for shelll.rb to be:

  • 'You only need to type the unique prefix of a command to run it. geordi rs will work as well.'

I changed that to:

  • 'You only need to type the unique prefix of a command to run it. geordi sh will work as well.'

Also, the rspec command only printed a hint when not using parallel_tests, I moved the code down to run it outside this if/else.

Is that correct?

Looks correct, thanks 👍

Copy link
Member

@codener codener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

(Please remember to use english PR titles.)

README.md Outdated Show resolved Hide resolved
lib/geordi/commands/chromedriver_update.rb Outdated Show resolved Hide resolved
lib/geordi/commands/setup.rb Outdated Show resolved Hide resolved
spec/did_you_know_spec.rb Outdated Show resolved Hide resolved
@steevokovsky-mkd steevokovsky-mkd changed the title [#186452718] 'Did you know' erweitern [#186452718] Add new hints to 'Did you know' Nov 16, 2023
@steevokovsky-mkd steevokovsky-mkd force-pushed the st/186452718-add-new-hints-for-did-you-know branch from 0f84d0d to d537b26 Compare November 16, 2023 11:22
Copy link
Member

@codener codener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

lib/geordi/commands/drop_databases.rb Show resolved Hide resolved
@steevokovsky-mkd steevokovsky-mkd force-pushed the st/186452718-add-new-hints-for-did-you-know branch from d537b26 to 0ed2cde Compare November 17, 2023 06:05
@steevokovsky-mkd steevokovsky-mkd merged commit 0ed2cde into master Nov 17, 2023
3 checks passed
@steevokovsky-mkd steevokovsky-mkd deleted the st/186452718-add-new-hints-for-did-you-know branch November 17, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants