Improve/fix interrupt handling in locale Rails console #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecden
reviewed
Dec 6, 2023
| end | ||
|
|
||
| # This part will never be reached when `exec` is true |
There was a problem hiding this comment.
Had to google once to find out how exec works.
For my understanding: This part is never reached because Kernel#exec replaces the current process (geordi) with the process called by exec (rails console)?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, hitting Ctrl + C in a Rails console started by
geordi console, the shell would get stuck between bash and console, effectively broken. By usingexecinstead ofsystem, this can be fixed without having to implement SIGINT handling in Geordi.See story #186280123.