Use dbdrop and dbcreate before restoring a postgres dump #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codener
approved these changes
Feb 20, 2024
Comment on lines
+65
to
+66
| drop_command = 'dropdb --if-exists ' << config['database'].to_s | ||
| create_command = 'createdb ' << config['database'].to_s |
There was a problem hiding this comment.
TIL!
However, dropdb and createdb have only been added in Postgres 12. This change will break restoring Postgres dumps for all folks on Postgres 11 and below. However, Postgres 11 apparently is EOL, so probably this is fine.
There was a problem hiding this comment.
dropdb is shipped with postgresql-client package, so any postgres user should have it.
Yes, but not in a docker setup. |
brunosedler
force-pushed
the
bs/improve-dump-load-process
branch
from
8274cac
to
caf6ecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.