Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotfile found in package root #73

Closed
tdslot opened this issue Dec 15, 2021 · 7 comments · Fixed by #229
Closed

Dotfile found in package root #73

tdslot opened this issue Dec 15, 2021 · 7 comments · Fixed by #229
Labels
P-Makedeb Issues revolving around makedeb. S-Critical Severely degrades performance, functionality, or results in highly undesirable behavior. T-Defect Bugs, crashes, or any other behavior leading to loss of functionality

Comments

@tdslot
Copy link

tdslot commented Dec 15, 2021

Issue

Environment

On MacOS

brew install lima
limactl start default

Run build in container with lima:

nerdctl run --rm -it -v \
          (pwd)/debbuild:/results \
          --entrypoint bash ghcr.io/prebuiltmpr/mpr-builder:focal

Version:

builder@277920aa859f:/results$ makedeb --version
makedeb 8.5.9-1
Alpha Release
Installed from APT

Problem

Can't not find dot files, but no dot files inside $pkgdir:

make[3]: Nothing to be done for 'install-exec-am'.
 /usr/bin/mkdir -p '/results/libmxf/pkg/libmxf/usr/lib/pkgconfig'
 /usr/bin/install -c -m 644 libMXF-1.0.pc '/results/libmxf/pkg/libmxf/usr/lib/pkgconfig'
make[3]: Leaving directory '/results/libmxf/src/libmxf'
make[2]: Leaving directory '/results/libmxf/src/libmxf'
make[1]: Leaving directory '/results/libmxf/src/libmxf'
[#] Tidying install...
  [->] Removing libtool files...
  [->] Purging unwanted files...
  [->] Removing static library files...
  [->] Stripping unneeded symbols from binaries and libraries...
  [->] Compressing man and info pages...
[#] Checking for packaging issues...
[!] Dotfile found in package root '/results/libmxf/pkg/libmxf/.*'
builder@277920aa859f:/results/libmxf$ ls -A
PKGBUILD  libmxf  pkg  src
builder@277920aa859f:/results/libmxf$ cd pkg/libmxf/
builder@277920aa859f:/results/libmxf/pkg/libmxf$ ls -A
usr
builder@277920aa859f:/results/libmxf/pkg/libmxf$

My PKGBUILD file:

# Maintainer: 

pkgname=libmxf
_commit=9b9860d
pkgver=1.0.4.$_commit
pkgrel=1
pkgdesc="libMXF is a low-level C library for reading and writing the SMPTE ST 377-1 MXF file format."
arch=('x86_64')
url="https://sourceforge.net/p/bmxlib/libmxf/ci/master/tree/"
license=('BSD 3-clause license')
makedepends=('uuid-dev' 'git' 'fakeroot' 'make' 'automake' 'autoconf' 'libtool' 'build-essential')
provides=('libmxf')
conflicts=('libmxf')
source=("git+https://git.code.sf.net/p/bmxlib/libmxf.git")
sha256sums=('SKIP')

prepare() {
    cd $pkgname
    git checkout $_commit
}

build() {
    cd $pkgname
    bash autogen.sh
    bash ./configure --prefix=/usr --disable-examples CFLAGS="-std=gnu99"
    make -j$(nproc)
}

package() {
    cd $pkgname
    make DESTDIR="$pkgdir" prefix="/usr" install
}


Installation source

makedeb Package Repository (MPR)

Installed release type

Alpha

Installed makedeb version

makedeb 8.5.9-1 Alpha Release

Installed makepkg version

makepkg-template (pacman) 6.0.0

@tdslot tdslot added the bug label Dec 15, 2021
@hwittenborn hwittenborn added P-Makedeb Issues revolving around makedeb. S-Critical Severely degrades performance, functionality, or results in highly undesirable behavior. T-Defect Bugs, crashes, or any other behavior leading to loss of functionality and removed bug labels Jan 16, 2022
@hwittenborn
Copy link
Member

Does this still happen on the latest releases @tdslot?

@tdslot
Copy link
Author

tdslot commented Apr 4, 2022

I tested with podman and lima. Yes it happen. But with docker no issue with that.

@hwittenborn
Copy link
Member

Oh, it looks like it's considering .* to be a directory because it didn't find anything else. I have no clue why this is only happening in podman and lima, but I'll get a fix going shortly.

@hwittenborn
Copy link
Member

Actually I'd like to test one more thing - Could you run ls -a from that directory you originally ran ls -A in your podman and lima containers so I can see what pops up?

@hwittenborn
Copy link
Member

Closing since there hasn't been a response. Feel free to reopen if you're still having the issue.

@JehhB
Copy link
Contributor

JehhB commented Sep 1, 2022

Hi, I am experiencing the same problem right now but it is happening for all packages for me.

For now I am aliasing makedeb to LIBMAKEPKG_LINT_PACKAGE_DOTFILES_SH=0 makedeb

but i think setting nullglob would be better so it still do check.

@Elsie19
Copy link
Sponsor Contributor

Elsie19 commented Sep 4, 2022

Hi, I am experiencing the same problem right now but it is happening for all packages for me.

For now I am aliasing makedeb to LIBMAKEPKG_LINT_PACKAGE_DOTFILES_SH=0 makedeb

but i think setting nullglob would be better so it still do check.

Same issue here.

@hwittenborn hwittenborn linked a pull request Sep 6, 2022 that will close this issue
hwittenborn added a commit that referenced this issue Sep 28, 2022
Co-authored-by: Hunter Wittenborn <hunter@hunterwittenborn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Makedeb Issues revolving around makedeb. S-Critical Severely degrades performance, functionality, or results in highly undesirable behavior. T-Defect Bugs, crashes, or any other behavior leading to loss of functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants