Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 fixes #188

Merged
merged 4 commits into from
Dec 17, 2021
Merged

Conversation

pekkarr
Copy link
Contributor

@pekkarr pekkarr commented Dec 16, 2021

This fixes issues that caused makehuman to crash during startup when using Python 3.10.1.

Notably collections.Callable and collections.MutableSet are moved to collections.abc submodule. I did also some refactoring to remove the OrderedSet class from language.py removing the need to use MutableSet.

There is also fix for PyQt5 throwing a ValueError during startup. I don't know if it was caused by Python 3.10 update or PyQt update. I am using PyQt 5.15.6.

logging.captureWarnings() has been around since Python 3.2
Collections abstract base classes were moved to `collections.abc` module
in Python 3.3 and they were removed from `collections` module in 3.10.
This gets rid of the deprecated reference to `collections.MutableSet`.

Starting from Python 3.7 the built-in `dict` class is also guaranteed to
preserve order, which can be used after dropping support for Python 3.6.
`QProgressBar.setValue()` and `QtCore.QSize()` expect integer arguments
and throw `TypeError` if they are called with a float.
@joepal1976
Copy link
Contributor

Thank you, that is very helpful

@joepal1976 joepal1976 merged commit 66febb0 into makehumancommunity:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants