Add support for Compare And Swap (CAS) to get, getMulti, and set #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justjake
commented
Apr 12, 2021
•
justjake
commented
- Some monkeying around with directory structure to make build output directory more coherent
- get and getMutli return CAS
- set, delete, etc take CAS option
blackmad
approved these changes
Apr 12, 2021
| }); | ||
| } | ||
| const logger = this.options.logger; | ||
|
|
||
| // TODO: support flags, support version (CAS) | ||
| this.incrSeq(); | ||
| const expiration = makeExpiration((options || {}).expires || this.options.expires); | ||
| const expiration = makeExpiration( | ||
| (options || {}).expires || this.options.expires |
There was a problem hiding this comment.
this is on modern TS so we can do options?.expires now, forgot I think when I wrote this
There was a problem hiding this comment.
TODO. I want to get to this in the next PR where I remove callbacks!
Comment on lines
+63
to
+64
| * If Value and Extras are of type Buffer, then return type WhenBuffer. Otherwise, | ||
| * return type NotBuffer. |
There was a problem hiding this comment.
mention that this is just for hacky tests?
src/memjs/memjs.ts
Outdated
Comment on lines
87
to
101
| export interface GetResult<Value = MaybeBuffer, Extras = MaybeBuffer> { | ||
| value: Value; | ||
| extras: Extras; | ||
| cas: CASToken | undefined; | ||
| } | ||
|
|
||
| export type GetMultiResult< | ||
| Keys extends string = string, | ||
| Value = MaybeBuffer, | ||
| Extras = MaybeBuffer | ||
| > = { | ||
| [K in Keys]: GetResult<Value, Extras>; | ||
| }; | ||
|
|
||
| class Client<Value = MaybeBuffer, Extras = MaybeBuffer> { |
There was a problem hiding this comment.
is all this really for tests? I should suck it up and make them just be all buffers
justjake
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.