[WEB-536] fix: analytics highlight while switching between scope_and_demand and custom tab.
#3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_demand` and `custom` tab.
gurusainath
approved these changes
Feb 23, 2024
sriramveeraghanta
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Analytics tab highlight was not being shown when we switch between scope_and_demand
andcustom` tabs inside the page. This was due to the changes in the URL while switching between tabs as the highlight logic was checking for an exact match in the URL.Solution
Updated the highlight logic to check if the URL includes
analyticsin it.This PR is linked to WEB-536