Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

WIP Add uniswapv3 #209

Merged
merged 39 commits into from Sep 8, 2021
Merged

WIP Add uniswapv3 #209

merged 39 commits into from Sep 8, 2021

Conversation

MikeHathaway
Copy link
Contributor

@MikeHathaway MikeHathaway commented Aug 2, 2021

This is pending: merging Calldata updates to pymaker, the addition of integration tests for multihop swaps, as well as various cleanups such as pushing the completed UniswapV3 README.

Mike added 25 commits February 16, 2021 15:29
@MikeHathaway MikeHathaway changed the title WIP: Add uniswapv3 WIP Add uniswapv3 Aug 2, 2021
@MikeHathaway MikeHathaway reopened this Aug 2, 2021
@MikeHathaway MikeHathaway marked this pull request as draft August 2, 2021 20:13
@MikeHathaway MikeHathaway marked this pull request as ready for review September 7, 2021 23:30
@MikeHathaway MikeHathaway merged commit 57b88da into makerdao:master Sep 8, 2021
@mLewisLogic
Copy link

@MikeHathaway Heyo, sorry to necro this one (I know it's not actively being developed).
Just wanted to ask what "WIP" meant in the context of this work, if you recall.
Missing functionality? Minimal testing? Known "send all yer tokens to 0x00..00" bugs?

It seems like the most functional V3 wrapper I've found for Python. Most other libs I've read are in pretty rough shape, but this one looks meticulously written. Hoping to use it if the dragons aren't too scary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants