PE-1184: 2023-02-03 Governance Spell #311

godsflaw · 2023-01-30T14:45:30Z

Description

Contribution Checklist

PR title starts with (PE-<TICKET_NUMBER>)
Code approved
Tests approved
CI Tests pass

Checklist

* update dss-test and add foundry.toml * add chainid export * add l2 tests WITH TODOs for Spell addresses * add balance check for PP

This reverts commit 102a4d5.

godsflaw · 2023-02-02T15:54:45Z

Went with the default value of 0.1 ETH for make fund-pause-proxy on mainnet. This is a foot shooting prevention measure. I will run this locally with 0.5ether though.`

This is in simulation:

$ make fund-pause-proxy
./scripts/fund-pause-proxy.sh
Pause Proxy ETH balance (wei) before Bombshell: 0
Deploying Bombshell with 0.1ether...
Bombshell located at: 0x2EDf0b73aD9a114a42C792622021E2d2a47E6192
    https://etherscan.io/address/0x2EDf0b73aD9a114a42C792622021E2d2a47E6192
Pause Proxy ETH balance (wei) after Bombshell: 100000000000000000
$ bc
>>> scale=18
>>> 100000000000000000/10^18
.100000000000000000
>>>

on mainnet:

$ make fund-pause-proxy
./scripts/fund-pause-proxy.sh
Pause Proxy ETH balance (wei) before Bombshell: 0
Deploying Bombshell with 0.5ether...
Bombshell located at: 0x2EDf0b73aD9a114a42C792622021E2d2a47E6192
    https://etherscan.io/address/0x2EDf0b73aD9a114a42C792622021E2d2a47E6192
Pause Proxy ETH balance (wei) after Bombshell: 500000000000000000
$ bc
>>> scale=18
>>> 500000000000000000/10^18
.500000000000000000
>>>

Pause Proxy Balance:
https://etherscan.io/address/0xBE8E3e3618f7474F8cB1d074A26afFef007E98FB

* Add Opt & Arb relay calls * Fix tests & fix typo * Add starknet L2spell test + Arb gov relay balance check * Update src/test/starknet.t.sol Co-authored-by: Christopher Mooney <chris@dod.net> --------- Co-authored-by: Christopher Mooney <chris@dod.net>

src/DssSpell.t.sol

Co-authored-by: rockyfour <115617270+rockyfour@users.noreply.github.com>

rockyfour

Looks good to deploy.

Optimism l2 spell -
- code ok (https://optimistic.etherscan.io/address/0x9495632F53Cc16324d2FcFCdD4EB59fb88dDab12#code)
- configured dstDomain ok ("ETH-MAIN-A")
- configured teleport gateway matches l2TeleportGateway in l1 OPTIMISM_TELEPORT_BRIDGE
Arbitrum l2 spell ok (https://arbiscan.io/address/0x852CCBB823D73b3e35f68AD6b14e29B02360FD3d#code)
- code ok ()
- configured dstDomain ok ("ETH-MAIN-A")
- configured teleport gateway matches l2TeleportGateway in l1 ARBITRUM_TELEPORT_BRIDGE
Starknet l2 spell -
- declared addresses ok:
  - dai matches STARKNET_DAI_BRIDGE l2Dai - hex(385291772725090318157700937045086145273563247402457518748197066808155336371)
  - bridge matches STARKNET_DAI_BRIDGE l2DaiBridge - hex(3326542335218638260710262166293903627998802370811525948909206799059756478048)
  - bridge_legacy matches STARKNET_DAI_BRIDGE_LEGACY l2DaiBridge - hex(30097160908876648820186558578205092597541264579458245618642493561688286878)
  - teleport_gateway matches STARKNET_TELEPORT_BRIDGE l2TeleportGateway - hex(2576156530550162489556572307842752856275393324011611706622942743423291814452)
  - gov_relay_legacy matches STARKNET_GOV_RELAY_LEGACY l2GovernanceRelay - hex(787160384835569379705326849547148806310979384177683342024625021854735775346)
- code of old gov relay and bridge denials ok:
  - dai is already warded to the newer gov relay - 2694177356735021486157429760236097264988741722222124772754810418722371262171
  - bridge is already warded to newer gov relay
  - teleport_gateway is already to by newer gov relay
  - dai is already warded to newer bridge - 3326542335218638260710262166293903627998802370811525948909206799059756478048
- code of teleport deactivation ok -
  - coded domain ok("ETH-MAIN-A")
- diff with starknet goerli spell ok (https://www.diffchecker.com/FTM2aaV2/)
OPT_MAX_GAS ok
ARB_MAX_GAS, ARB_GAS_PRICE_BID, ARB_MAX_SUBMISSION_COST, ARB_L1_CALL_VALUE - ok
made sure that a low value ARB_MAX_SUBMISSION_COST would make the test fail
STA_GAS_USAGE_ESTIMATION, STA_GAS_PRICE, STA_L1_CALL_VALUE - match goerli
diff with goerli -ok
-hash and copy ok
tests pass:
Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1558777)
Test result: ok. 1 passed; 0 failed; finished in 261.71ms

Running 20 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487101211439)
[PASS] testAuthInSources() (gas: 9223371487098953477)
[PASS] testBytecodeMatches() (gas: 2446573)
[PASS] testCastCost() (gas: 1281337)
[PASS] testChainlogValues() (gas: 9434183)
[PASS] testChainlogVersionBump() (gas: 4620064)
[PASS] testContractSize() (gas: 9006)
[PASS] testDeployCost() (gas: 2432087)
[PASS] testFailNotScheduled() (gas: 14331)
[PASS] testFailTooEarly() (gas: 13901)
[PASS] testFailTooLate() (gas: 13856)
[PASS] testFailWrongDay() (gas: 13901)
[PASS] testGeneral() (gas: 35375146)
[PASS] testL2ArbitrumSpell() (gas: 11659081)
[PASS] testL2OptimismSpell() (gas: 11294804)
[PASS] testNextCastTime() (gas: 353681)
[PASS] testOnTime() (gas: 1277187)
[PASS] testPSMs() (gas: 2786001)
[PASS] testPayments() (gas: 1413694)
[PASS] testUseEta() (gas: 352299)
Test result: ok. 20 passed; 0 failed; finished in 26.31s

brianmcmichael

Office hours off
hash and date correct
Scripts match(ish) Goerli
Payment addresses and amounts match gov copy
Tests public and passing
l2 spells verified
l2 tests validate post-state

Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1558777)
Test result: ok. 1 passed; 0 failed; finished in 19.72s

Running 20 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487101211439)
[PASS] testAuthInSources() (gas: 9223371487098953477)
[PASS] testBytecodeMatches() (gas: 2459253)
[PASS] testCastCost() (gas: 1281337)
[PASS] testChainlogValues() (gas: 9434183)
[PASS] testChainlogVersionBump() (gas: 4620064)
[PASS] testContractSize() (gas: 9006)
[PASS] testDeployCost() (gas: 2444731)
[PASS] testFailNotScheduled() (gas: 14331)
[PASS] testFailTooEarly() (gas: 13901)
[PASS] testFailTooLate() (gas: 13856)
[PASS] testFailWrongDay() (gas: 13901)
[PASS] testGeneral() (gas: 35389637)
[PASS] testL2ArbitrumSpell() (gas: 11659081)
[PASS] testL2OptimismSpell() (gas: 11294804)
[PASS] testNextCastTime() (gas: 353681)
[PASS] testOnTime() (gas: 1277187)
[PASS] testPSMs() (gas: 2786001)
[PASS] testPayments() (gas: 1413407)
[PASS] testUseEta() (gas: 352299)
Test result: ok. 20 passed; 0 failed; finished in 536.18s

rockyfour

Good to publish and archive.

compiler version - ok
optimizations off - ok
license - ok
code matches repo - ok
dss-exec-lib address - ok

tests pass:
[⠒] Compiling...
[⠔] Compiling 4 files with 0.8.16
[⠢] Solc 0.8.16 finished in 1.76s
Compiler run successful

Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1558777)
Test result: ok. 1 passed; 0 failed; finished in 23.22s

Running 20 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487101211439)
[PASS] testAuthInSources() (gas: 9223371487098953477)
[PASS] testBytecodeMatches() (gas: 2459253)
[PASS] testCastCost() (gas: 1281337)
[PASS] testChainlogValues() (gas: 9434183)
[PASS] testChainlogVersionBump() (gas: 4620064)
[PASS] testContractSize() (gas: 9006)
[PASS] testDeployCost() (gas: 2444731)
[PASS] testFailNotScheduled() (gas: 14331)
[PASS] testFailTooEarly() (gas: 13901)
[PASS] testFailTooLate() (gas: 13856)
[PASS] testFailWrongDay() (gas: 13901)
[PASS] testGeneral() (gas: 35391734)
[PASS] testL2ArbitrumSpell() (gas: 11659081)
[PASS] testL2OptimismSpell() (gas: 11294804)
[PASS] testNextCastTime() (gas: 353681)
[PASS] testOnTime() (gas: 1277187)
[PASS] testPSMs() (gas: 2786001)
[PASS] testPayments() (gas: 1413867)
[PASS] testUseEta() (gas: 352299)
Test result: ok. 20 passed; 0 failed; finished in 879.65s

brianmcmichael

Verified code matches(ish) github.
All compiler options good.

Tests pass.
Good for publish.

Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠃] Compiling...
[⠑] Compiling 4 files with 0.8.16
[⠔] Solc 0.8.16 finished in 3.73s
Compiler run successful

Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1558777)
Test result: ok. 1 passed; 0 failed; finished in 19.47s

Running 20 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487101211439)
[PASS] testAuthInSources() (gas: 9223371487098953477)
[PASS] testBytecodeMatches() (gas: 2459253)
[PASS] testCastCost() (gas: 1281337)
[PASS] testChainlogValues() (gas: 9434183)
[PASS] testChainlogVersionBump() (gas: 4620064)
[PASS] testContractSize() (gas: 9006)
[PASS] testDeployCost() (gas: 2444731)
[PASS] testFailNotScheduled() (gas: 14331)
[PASS] testFailTooEarly() (gas: 13901)
[PASS] testFailTooLate() (gas: 13856)
[PASS] testFailWrongDay() (gas: 13901)
[PASS] testGeneral() (gas: 35391734)
[PASS] testL2ArbitrumSpell() (gas: 11659081)
[PASS] testL2OptimismSpell() (gas: 11294804)
[PASS] testNextCastTime() (gas: 353681)
[PASS] testOnTime() (gas: 1277187)
[PASS] testPSMs() (gas: 2786001)
[PASS] testPayments() (gas: 1413637)
[PASS] testUseEta() (gas: 352299)
Test result: ok. 20 passed; 0 failed; finished in 558.44s

rockyfour

Archive ok, good to merge.

PE-1184: 2023-02-03 Governance Spell

91e74ba

godsflaw added Priority: Critical Status: Work In Progress labels Jan 30, 2023

godsflaw requested review from iamchrissmith, brianmcmichael and rockyfour January 30, 2023 14:45

godsflaw self-assigned this Jan 30, 2023

godsflaw requested a review from olivdb January 30, 2023 14:52

godsflaw and others added 6 commits January 31, 2023 12:11

DAI payouts

e301e63

PE-1184 l2 tests (#312)

6251356

* update dss-test and add foundry.toml * add chainid export * add l2 tests WITH TODOs for Spell addresses * add balance check for PP

fix date

102a4d5

Revert "fix date"

d496aac

This reverts commit 102a4d5.

fix date

f5dc5e0

Add make fund-pause-proxy utility

4c2a67c

godsflaw and others added 3 commits February 2, 2023 11:03

fix etherscan URL

0c95420

Pe 1184 : add relay to L2 (#315)

4289e7c

* Add Opt & Arb relay calls * Fix tests & fix typo * Add starknet L2spell test + Arb gov relay balance check * Update src/test/starknet.t.sol Co-authored-by: Christopher Mooney <chris@dod.net> --------- Co-authored-by: Christopher Mooney <chris@dod.net>

set the RPC URL correctly for foundry

ef16d8e

rockyfour reviewed Feb 2, 2023

View reviewed changes

src/DssSpell.t.sol Outdated Show resolved Hide resolved

godsflaw and others added 2 commits February 2, 2023 15:12

Update src/DssSpell.t.sol

74358de

Co-authored-by: rockyfour <115617270+rockyfour@users.noreply.github.com>

Fix quoting in shell scripts

5f86ba0

godsflaw added Status: Ready for Review and removed Status: Work In Progress labels Feb 3, 2023

maciejka and others added 4 commits February 3, 2023 09:32

disable starknet teleport (#316)

76164c4

migrated to starkscan link for code

976e153

adding governance copy

c580325

fixed governance copy to raw

b4f914f

rockyfour previously approved these changes Feb 3, 2023

View reviewed changes

brianmcmichael previously approved these changes Feb 3, 2023

View reviewed changes

published spell address

4722588

godsflaw dismissed stale reviews from brianmcmichael and rockyfour via 4722588 February 3, 2023 17:35

rockyfour previously approved these changes Feb 3, 2023

View reviewed changes

brianmcmichael previously approved these changes Feb 3, 2023

View reviewed changes

archived spell

99e277a

godsflaw dismissed stale reviews from brianmcmichael and rockyfour via 99e277a February 3, 2023 18:26

rockyfour approved these changes Feb 4, 2023

View reviewed changes

brianmcmichael approved these changes Feb 6, 2023

View reviewed changes

brianmcmichael merged commit b528982 into master Feb 6, 2023

brianmcmichael deleted the PE-1184 branch February 6, 2023 22:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PE-1184: 2023-02-03 Governance Spell #311

PE-1184: 2023-02-03 Governance Spell #311

godsflaw commented Jan 30, 2023 •

edited

Loading

godsflaw commented Feb 2, 2023 •

edited

Loading

rockyfour left a comment

brianmcmichael left a comment

rockyfour left a comment

brianmcmichael left a comment

rockyfour left a comment

PE-1184: 2023-02-03 Governance Spell #311

PE-1184: 2023-02-03 Governance Spell #311

Conversation

godsflaw commented Jan 30, 2023 • edited Loading

Description

Contribution Checklist

Checklist

godsflaw commented Feb 2, 2023 • edited Loading

rockyfour left a comment

Choose a reason for hiding this comment

brianmcmichael left a comment

Choose a reason for hiding this comment

rockyfour left a comment

Choose a reason for hiding this comment

brianmcmichael left a comment

Choose a reason for hiding this comment

rockyfour left a comment

Choose a reason for hiding this comment

godsflaw commented Jan 30, 2023 •

edited

Loading

godsflaw commented Feb 2, 2023 •

edited

Loading