Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pe 1184 : add relay to L2 #315

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Pe 1184 : add relay to L2 #315

merged 4 commits into from
Feb 2, 2023

Conversation

olivdb
Copy link
Collaborator

@olivdb olivdb commented Feb 2, 2023

Description

Contribution Checklist

  • PR title starts with (PE-<TICKET_NUMBER>)
  • Code approved
  • Tests approved
  • CI Tests pass

Checklist

  • Every contract variable/method declared as public/external private/internal
  • Consider if this PR needs the officeHours modifier override
  • Verify expiration (30 days unless otherwise specified)
  • Verify hash in the description matches here
  • Validate all addresses used are in changelog or known
  • Notify any external teams affected by the spell so they have the opportunity to review
  • Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
  • Verify mainnet contract on etherscan
  • Change test to use mainnet spell address and deploy timestamp
  • Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
  • squash and merge this PR

@olivdb olivdb mentioned this pull request Feb 2, 2023
15 tasks
@olivdb olivdb requested review from godsflaw and removed request for godsflaw February 2, 2023 15:21
Copy link
Contributor

@godsflaw godsflaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change and a question for you.

src/DssSpell.t.sol Show resolved Hide resolved
src/test/starknet.t.sol Outdated Show resolved Hide resolved
Co-authored-by: Christopher Mooney <chris@dod.net>
@godsflaw godsflaw merged commit 4289e7c into PE-1184 Feb 2, 2023
brianmcmichael pushed a commit that referenced this pull request Feb 6, 2023
* PE-1184: 2023-02-03 Governance Spell

* DAI payouts

* PE-1184 l2 tests (#312)

* update dss-test and add foundry.toml

* add chainid export

* add l2 tests WITH TODOs for Spell addresses

* add balance check for PP

* fix date

* Revert "fix date"

This reverts commit 102a4d5.

* fix date

* Add make fund-pause-proxy utility

* fix etherscan URL

* Pe 1184 : add relay to L2  (#315)

* Add Opt & Arb relay calls

* Fix tests & fix typo

* Add starknet L2spell test + Arb gov relay balance check

* Update src/test/starknet.t.sol

Co-authored-by: Christopher Mooney <chris@dod.net>

---------

Co-authored-by: Christopher Mooney <chris@dod.net>

* set the RPC URL correctly for foundry

* Update src/DssSpell.t.sol

Co-authored-by: rockyfour <115617270+rockyfour@users.noreply.github.com>

* Fix quoting in shell scripts

* disable starknet teleport (#316)

* migrated to starkscan link for code

* adding governance copy

* fixed governance copy to raw

* published spell address

* archived spell

---------

Co-authored-by: Chris Smith <1408372+iamchrissmith@users.noreply.github.com>
Co-authored-by: olivdb <ovdbigge@gmail.com>
Co-authored-by: rockyfour <115617270+rockyfour@users.noreply.github.com>
Co-authored-by: olivdb <olivdb@protonmail.com>
Co-authored-by: Maciej Kamiński <aundumla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants