Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cascade delete logs referencing deleted transaction #11

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Cascade delete logs referencing deleted transaction #11

merged 1 commit into from
Dec 3, 2019

Conversation

rmulhol
Copy link

@rmulhol rmulhol commented Dec 3, 2019

  • Prevents constraint violation when db wiped in arbitrary order
    during tests

@rmulhol
Cascade delete logs referencing deleted transaction
a302616 
- Prevents constraint violation when db wiped in arbitrary order
  during tests
Gslaughl
Gslaughl approved these changes Dec 3, 2019
View reviewed changes
Copy link

@Gslaughl Gslaughl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

elizabethengelman
elizabethengelman approved these changes Dec 3, 2019
View reviewed changes
Copy link

@elizabethengelman elizabethengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rmulhol rmulhol merged commit 9355786 into staging Dec 3, 2019
@rmulhol rmulhol deleted the handle-deleted-tx branch December 3, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabethengelman elizabethengelman elizabethengelman approved these changes

@Gslaughl Gslaughl Gslaughl approved these changes

@m0ar m0ar Awaiting requested review from m0ar

@yaoandrew yaoandrew Awaiting requested review from yaoandrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rmulhol @elizabethengelman @Gslaughl