-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry] proptest for parsers.rs #203
Conversation
Hi! I didn't know proptest, this seems nice. From what I understand, it will test multiple scenarios based on the format you give and will change parts of it each time?
I may be mistaken but each makair device will have its own ID which is given in the device_id field. You can find more information in this issue: #120 I'll let @dsferruzza rule on this one but it seems good for me (maybe just remove the commented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have few minor changes to request but otherwise this looks good to me!
Co-Authored-By: David Sferruzza <david.sferruzza@gmail.com>
Co-Authored-By: David Sferruzza <david.sferruzza@gmail.com>
Co-Authored-By: David Sferruzza <david.sferruzza@gmail.com>
Co-Authored-By: David Sferruzza <david.sferruzza@gmail.com>
Co-Authored-By: David Sferruzza <david.sferruzza@gmail.com>
Co-Authored-By: David Sferruzza <david.sferruzza@gmail.com>
I think that all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: David Sferruzza <david.sferruzza@gmail.com>
Co-Authored-By: David Sferruzza <david.sferruzza@gmail.com>
Co-Authored-By: David Sferruzza <david.sferruzza@gmail.com>
Co-Authored-By: David Sferruzza <david.sferruzza@gmail.com>
Thanks @ronanM! |
I have added
proptest
for parsingBootMessage
(but I don't understood thedevice_id
logic).If you found that useful, i could continue with other messages.