Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootbox 5.0 ship list #665

Closed
9 tasks done
tiesont opened this issue Jun 9, 2018 · 24 comments
Closed
9 tasks done

Bootbox 5.0 ship list #665

tiesont opened this issue Jun 9, 2018 · 24 comments
Assignees
Milestone

Comments

@tiesont
Copy link
Member

tiesont commented Jun 9, 2018

  • Generate minified file for bootbox.js
  • Generate minified file for bootbox.locales.js
  • Generate minified file for bootbox.all.js (combined bootbox.js and bootbox.locales.js)
  • Generate zip archive for Releases tab
  • Update CDNjs
  • Update NPM (?)
  • Update bower (?)
  • Update NuGet
  • Update README to note locales being pulled to separate file
  • Update documentation site for new and updated features
@tiesont
Copy link
Member Author

tiesont commented Jul 24, 2018

@tarlepp I can update the NuGet package, and I think CDNjs updates itself based on the repo being updated, but do you know how bower and/or NPM are updated? I was able to do a clean pull-request from v5.x to master on my fork, so I think that's all I need to do at this point to go live with version 5.

I have a draft of a 5.0 release setup, so I just need to update the files there to the most recent updates, and that will be squared away.

Would be nice to definitively close the "doesn't work with BS4" issues.

@meglio
Copy link

meglio commented Aug 23, 2018

So, is there a way to npm-install the 5.0 version? Is it already stable enough to be used in production?

@tiesont
Copy link
Member Author

tiesont commented Aug 23, 2018

I don't use npm, but I don't think so. I'd have to read up on how that gets updated (or if I even can), which is one reason this hasn't been pushed out yet.

I've used this in at least one site that went to production, so I would say yes. There really aren't any code changes I plan on making - I just need to get all the external updates squared away so that everything is in sync.

@kounelios13
Copy link

@tiesont As far as I know only the owner of the npm package can update it on the NPM repo

@Trippnology
Copy link

So, is there a way to npm-install the 5.0 version?

This should get you by until npm gets updated: npm i github:makeusabrew/bootbox#v5.x

@lddubeau
Copy link

@tiesont Did you consider forking the project? I mean spawning a new project derived from this one, under a new name, with you as owner? Looking at the profile of the project owner, I don't see any activity on github in 2018, almost nothing in 2017, with the last year of substantial activity on github being 2016.

@tiesont
Copy link
Member Author

tiesont commented Jan 25, 2019

@lddubeau Considered, yes, but I'd rather keep this project going, if possible.

@nash-ye
Copy link

nash-ye commented Feb 11, 2019

We are using this library for awhile, what left to push the support for Bootstrap v4?

@tiesont
Copy link
Member Author

tiesont commented Feb 15, 2019

@nash-ye Depends on what kind of support you mean. I can push my updates into the master branch, which would correct the templates for both BS3 and BS4 support, and add a few new features. Neither I nor @tarlepp can update the external resources like npm, bower, etc.. So, we haven't updated master until doing the aforementioned tasks is possible.

@peterfarrell
Copy link

@tiesont Could you update master anyways? I don't use this project via NPM or bower so that seems like a different issue that shouldn't hold up an update.

@nash-ye
Copy link

nash-ye commented Feb 19, 2019

@tiesont I agree with @peterfarrell . If it's impossible to update NPM, Bower..etc, I would suggest to create another repository or to deprecate the packages in the 3rd-party services. This library is very helpful and many projects are switching to BS4.

@lddubeau
Copy link

As I suggested a while back, I've forked bootbox. The fork includes tiesont's work for BS4 support. Each new version is pushed to npm. The latest release is still "alpha" because there were a few surprises during the fork that still need to be addressed. I'm nonetheless using it in production. (Then again I don't use all features so YMMV.) Folks who want to use it should pay special attention to this document.

@tiesont
Copy link
Member Author

tiesont commented Feb 27, 2019

Okay, @lddubeau's work inspired me to see if I could correct things like the broken tests and whatnot. It did require me to install npm, which I didn't really want to do (we don't use node or npm at work), but after about a day and a half of work, I think everything I can get squared away, is. This was all done on my fork, so I'll be working on pushing my changes into master here and then pushing a new item into the Releases tab. Once that's done, I don't see myself making much in the way of updates, since I like the work @lddubeau has done on his version (especially if you're looking for a TypeScript version).

So, be on the lookout for a 5.0 release sometime this week.

@tiesont
Copy link
Member Author

tiesont commented Feb 27, 2019

Okay, folks - I went ahead and pushed out a 5.0 release. I am updating the NuGet package as I write this, but I have no idea if/when CDNjs, npm, or bower will be updated. I think CDNjs auto-updates from the contents of the repository, so that should take care of itself. If npm and bower do the same, great. Otherwise, unless/until @makeusabrew pops his head in, those will not be updated.

@t-veron
Copy link

t-veron commented Feb 28, 2019

For npm you must publish your package with the command « npm-publish »

Please can you do it ?

https://docs.npmjs.com/updating-your-published-package-version-number

https://eladnava.com/publishing-your-first-package-to-npm/

@tiesont
Copy link
Member Author

tiesont commented Feb 28, 2019

@t-veron No, I can't. @makeusabrew is the owner of that package, and he hasn't been responding.

@max-ci
Copy link

max-ci commented Feb 28, 2019

There is a possibility to install specific tag.

npm install makeusabrew/bootbox#v5.0.0

@tiesont is v5.0.0 tag pointing to latest master?

@tiesont
Copy link
Member Author

tiesont commented Feb 28, 2019

@max-ci Yes. 5.0.0 is the current master, pushed yesterday.

@tiesont
Copy link
Member Author

tiesont commented Mar 1, 2019

There are actually two owners listed on the npm package, so I sent an email to the other owner to see if I can be added there. If so, I'll publish this to npm, which will pretty much leave CDNjs as the one thing to fix (bower seems like it's going away, so not sure it's worth the effort to figure that one out). I'll update the docs with the workaround mentioned earlier, in the meantime.

@tiesont
Copy link
Member Author

tiesont commented Mar 7, 2019

Okay, npm should be updated. I'm not super familiar with npm, so I accidentally published everything and the kitchen sink to 5.0.0 (which I assume most of you don't want). So, unpublished that and published 5.0.1 that has the contents of the /dist and /src directories (in case someone wants the un-minified versions). Please let me know if it still seems broken.

@tiesont
Copy link
Member Author

tiesont commented Mar 13, 2019

Okay, cdnjs should be updated soon, then we can all rejoice in the awesomeness of this long-awaited release (I hear there is cake!). Kidding. But seriously, cdnjs is being updated. Once that's done, I'll update the docs and then close this issue.

Thank you for being patient.

@tiesont
Copy link
Member Author

tiesont commented Apr 3, 2019

Still waiting on cdnjs. Not sure when they'll get around to pulling this version in. In the meanwhile, you've a new locale option, Tamil, thanks to Kolappan Nathan. Thanks!

@ray73864
Copy link

ray73864 commented Jul 1, 2019

I'm not sure if this is an oversight or maybe i'm just missing something, but for some reason I can't use 'centerVertical' on a prompt.

It works 100% on dialogs and pretty sure alert boxes, but I can't get it to work on prompts at all.

I'm using it by doing:

bootbox.prompt({
  centerVertical: true,
  title: "My Test Title",
  callback: function(result) {  }
}).modal("show");

Just made sure i'm using the latest version (Was previously on 5.0.0 now on 5.1.3) and it is still not working.

@tiesont
Copy link
Member Author

tiesont commented Jul 1, 2019

@ray73864 Please open a new issue, rather than posting that here.

@tiesont tiesont closed this as completed Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants