Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on recent version of PostgreSQL #231

Closed
askpatrickw opened this issue Aug 13, 2018 · 4 comments
Closed

Test on recent version of PostgreSQL #231

askpatrickw opened this issue Aug 13, 2018 · 4 comments

Comments

@askpatrickw
Copy link
Contributor

I'm sure this project is not that dependent on the PostgreSQL version, but I am planning some upgrades and want to help-out where I can across my project dependencies so we're all staying current on the test matrix.

Currently django-leaflet is only testing on on 9.6.2
Latest 9.6 version is 9.6.10
Latest major version is 10.5

Django GIS supports 9.3+
https://docs.djangoproject.com/en/2.0/ref/contrib/gis/install/#requirements

I propose changing 9.6.2 to 9.6.10 and adding 10.5

I'm happy to to make the PR, but I'd like to get feedback on this first to prevent the many CI runs I caused with PR #229

@Gagaro
Copy link
Member

Gagaro commented Aug 15, 2018

I'm not sure we should test on both version. The fields should already be tested in Django with different psql versions and this would double our tests duration. Unless you see another reason to do it.

You can upgrade the version though, no problem there.

@askpatrickw
Copy link
Contributor Author

Hey @Gagaro Just to clarify... are you saying to update to version 10 or just the latest 9.6 release?
tx!

@Gagaro
Copy link
Member

Gagaro commented Sep 14, 2018

Either one of them.

@claudep
Copy link
Contributor

claudep commented Sep 14, 2020

Travis is currently using PostgreSQL 10. I don't think adding more versions is so much useful. I'd suggest to close this.

@Gagaro Gagaro closed this as completed Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants