Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis matrix #229

Closed
wants to merge 14 commits into from
Closed

Update travis matrix #229

wants to merge 14 commits into from

Conversation

askpatrickw
Copy link
Contributor

@askpatrickw askpatrickw commented Jul 30, 2018

I'm not setup to run Travis locally so I'm relying on the CI to verify this.

As in the commit message: Update the versions for travis

* Removed no longer supported version of Django (1.6, 1.7, 1.9, 1.10) 1.11 is LTS
* Added Django 2.0.7 explicitly
* Removed Python 3.5, kept 3.6 
* To support those changes, updated the matrix.exclude section to match.
* Kept allow_failures for Django Dev

Patrick and others added 7 commits July 13, 2018 10:56
* Removed no longer supported version of Django (1.6, 1.7, 1.9, 1.10) 1.11 is LTS
* Added Django 2.0.7 explicitly
* Removed Python 3.5, kept 3.6 and added 3.7
* To support those changes, updated the matrix.exclude section to match.
* Removed all allow_failures which seems to be a holdover from a previous
age where py3 was not well supported.
SQLITE3 was added to the standard library in Python 2.5 now that all
tested version are >2.5 it should no longer be neded.
It is needed for the spatial extension support, so I made it required only
for Py2.7 as it shoud not be required for Py3.
Travis does not support 3.7 yet. Tracking this in its own issue.
Also updated pysqlite to latest .3 version
@askpatrickw
Copy link
Contributor Author

askpatrickw commented Jul 30, 2018

OK, this looks ready to merge.
I don't understand why Django Dev fails. but hey, its Django Dev. Seem unrelated to my changes, but if others have more guidance, let me know.
I filed another issue to track adding Py3.7 to the matrix #230

NOTE: New GH feature, you can squash and merge right from the UI now.

@Gagaro
Copy link
Member

Gagaro commented Jul 31, 2018

Hi, thanks for the PR. A few remarks:

  • Removed no longer supported version of Django (1.6, 1.7, 1.9, 1.10) 1.11 is LTS
    • Please let them. Some people still relied on them. We will think about dropping them if they break with newer version of django,leaflet or if a new feature/optimization doesn't work with them. As long as they work correctly with the current version, there is no reason to remove them from travis.
  • Added Django 2.0.7 explicitly
    • 👍
  • Removed Python 3.5, kept 3.6
    • Django 1.11 and 2.0 both support Python 3.5. We must let it. And we should actually add 3.4 as they also both support it.
  • To support those changes, updated the matrix.exclude section to match.
  • Kept allow_failures for Django Dev
    • This is used to see if there are new dev required with the next Django version automatically before its release. Failures are indeed expected.

@askpatrickw
Copy link
Contributor Author

I added back 3.4 & 3.5.

While I understand your point on the older Django releases (I get it, people don't upgrade.). I think you should reconsider if actively enabling people to stay on old versions which are very likely to have security issues is a sound practice. 1.10 was End Of Life 8 Months ago and hasn't had a release in 11 months.

image

So if you want to add that back, you won't hurt my feelings, but I would counsel against it.

In the future, I'll open an Issue and get your input before I PR. I really wanted to get 2.0 added though, it had been sitting out there way too long.

@Gagaro
Copy link
Member

Gagaro commented Aug 1, 2018

I agree with you but some people are just stuck on older versions. Removing them from travis won't help them. They'll either try the latest version and hope it works or use the latest tested one.

At least with Travis we can document which versions still works.

More things have been released. updated and added those.
Added back the not supported versions of Django.
@askpatrickw
Copy link
Contributor Author

@Gagaro As you have requested and rolled forward and added even more new versions.

@Gagaro
Copy link
Member

Gagaro commented Aug 13, 2018

Thanks for the update, we're almost there 👍 . There are still two small things:

  • Travis can't parse the .travis.yml file. I think it is because of the indentation of
  - python: 2.7
      env: DJANGO_VERSION=dev DATABASE=sqlite	      env: DJANGO_VERSION=dev DATABASE=sqlite
  • You didn't add the 3.7 to the exclude matrix. Only the 2.0 to 2.2 (dev) should be tested with it.

I think it should be all good after that.

Patrick added 4 commits August 13, 2018 10:39
and fix indentation
This is so tedious... another reason to drop some of these version.
Moved 2.7 to the top of the excludes because its prettier in that order
Removed exclude for 3.5 and 1.11 that is supported
Removed exclude for 3.6 and 1.11 that is supported
Removed exclude for 3.5 Dev that is supported
Added excluded for 3.4 and 2.1 that is NOT supported
Added excluded for 3.4 and dev that is NOT supported
Added missing SQLITE and POSTGRES where missing
@askpatrickw
Copy link
Contributor Author

askpatrickw commented Aug 13, 2018

Thanks for being patient with me on this... ;-) Things are looking better.

Couple of items

  1. Without the fix from Travis for issue Add Python 3.7 to travis matrix #230 (they don't support 3.7 yet) we can either hold this PR till then, or move 3.7 to allowed failures.
  2. I'm looking into why all the Django-dev run version failed to make sure that's not a real issue.
  3. Need to update setup.py Classifiers

@askpatrickw
Copy link
Contributor Author

In looking at the Django-dev version failures... I don't see why we'd have path issues but the internet says AttributeError: /usr/lib/libgdal.so.1: undefined symbol: GDALGetMetadataDomainList is usually problem with your GDAL_LIBRARY_PATH. But for it to only fail with dev where 3.5|2.1|postgres passes points to something else.

No related issues in Django Bug Tracker.

Let me know how you'd like to proceed given those failures and then I'll do a final submit.

@askpatrickw
Copy link
Contributor Author

@Gagaro when you have some time, there are questions above for you to consider. tx!

Added 3.6 and 3.7
@Gagaro
Copy link
Member

Gagaro commented Aug 15, 2018

We can probably wait for travis to add it. Ping me when it's ok.

For the dev version, we are far from the next release, we can ignore it for now.

@claudep
Copy link
Contributor

claudep commented May 18, 2020

I guess this PR is now mostly outdated.

@Gagaro
Copy link
Member

Gagaro commented May 18, 2020

Yes it is, thanks for the cleanup.

@Gagaro Gagaro closed this May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants