-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update travis matrix #229
Update travis matrix #229
Conversation
merge from main repo
* Removed no longer supported version of Django (1.6, 1.7, 1.9, 1.10) 1.11 is LTS * Added Django 2.0.7 explicitly * Removed Python 3.5, kept 3.6 and added 3.7 * To support those changes, updated the matrix.exclude section to match. * Removed all allow_failures which seems to be a holdover from a previous age where py3 was not well supported.
SQLITE3 was added to the standard library in Python 2.5 now that all tested version are >2.5 it should no longer be neded.
It is needed for the spatial extension support, so I made it required only for Py2.7 as it shoud not be required for Py3.
Travis does not support 3.7 yet. Tracking this in its own issue.
Also updated pysqlite to latest .3 version
OK, this looks ready to merge. NOTE: New GH feature, you can squash and merge right from the UI now. |
Hi, thanks for the PR. A few remarks:
|
I added back 3.4 & 3.5. While I understand your point on the older Django releases (I get it, people don't upgrade.). I think you should reconsider if actively enabling people to stay on old versions which are very likely to have security issues is a sound practice. 1.10 was End Of Life 8 Months ago and hasn't had a release in 11 months. So if you want to add that back, you won't hurt my feelings, but I would counsel against it. In the future, I'll open an Issue and get your input before I PR. I really wanted to get 2.0 added though, it had been sitting out there way too long. |
I agree with you but some people are just stuck on older versions. Removing them from travis won't help them. They'll either try the latest version and hope it works or use the latest tested one. At least with Travis we can document which versions still works. |
More things have been released. updated and added those. Added back the not supported versions of Django.
@Gagaro As you have requested and rolled forward and added even more new versions. |
Thanks for the update, we're almost there 👍 . There are still two small things:
I think it should be all good after that. |
and fix indentation
This is so tedious... another reason to drop some of these version.
Moved 2.7 to the top of the excludes because its prettier in that order Removed exclude for 3.5 and 1.11 that is supported Removed exclude for 3.6 and 1.11 that is supported Removed exclude for 3.5 Dev that is supported Added excluded for 3.4 and 2.1 that is NOT supported Added excluded for 3.4 and dev that is NOT supported Added missing SQLITE and POSTGRES where missing
Thanks for being patient with me on this... ;-) Things are looking better. Couple of items
|
In looking at the Django-dev version failures... I don't see why we'd have path issues but the internet says No related issues in Django Bug Tracker. Let me know how you'd like to proceed given those failures and then I'll do a final submit. |
@Gagaro when you have some time, there are questions above for you to consider. tx! |
Added 3.6 and 3.7
We can probably wait for travis to add it. Ping me when it's ok. For the dev version, we are far from the next release, we can ignore it for now. |
I guess this PR is now mostly outdated. |
Yes it is, thanks for the cleanup. |
I'm not setup to run Travis locally so I'm relying on the CI to verify this.
As in the commit message: Update the versions for travis