Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to dynamically override LEAFLET_CONFIG, minor fixes, czech locale #101

Merged
merged 31 commits into from
Apr 21, 2015

Conversation

PetrDlouhy
Copy link
Contributor

I needed to set DEFAULT_CENTER and DEFAULT_ZOOM depending on the user city location. Here are changes which allow to set LEAFLET_CONFIG overrides in LeafletWidget init parameter. Documentation of this is also part of the PR.

manelclos and others added 30 commits January 7, 2015 17:15
@@ -501,6 +501,29 @@ Advanced usage
If empty values is provided, then map initialization is immediate.
And with a wrong value, the map is never initialized. :)

* ``settings_overrides``: Map with overrides to the default LEAFLET_CONFIG settings.
(Default: {}).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dict to override the default...

@leplatrem
Copy link
Collaborator

Nice contribution ! Thanks !

Would you mind adding a small test case please ?

@PetrDlouhy
Copy link
Contributor Author

OK, I will try.

@PetrDlouhy
Copy link
Contributor Author

Now it is with the test.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 81.8% when pulling 810b3f4 on PetrDlouhy:master into 4bd8d27 on makinacorpus:master.

@leplatrem leplatrem merged commit 810b3f4 into makinacorpus:master Apr 21, 2015
@leplatrem
Copy link
Collaborator

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants