-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to dynamically override LEAFLET_CONFIG, minor fixes, czech locale #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-leaflet into nonZero-hebrew_translation
…nimasmi/django-leaflet into nimasmi-django_compressor_compatibility
…to nonZero-master Conflicts: CHANGES
…into manelclos-master
…into manelclos-minzoom
Support Django 1.8 without GEOS (fixes makinacorpus#99)
@@ -501,6 +501,29 @@ Advanced usage | |||
If empty values is provided, then map initialization is immediate. | |||
And with a wrong value, the map is never initialized. :) | |||
|
|||
* ``settings_overrides``: Map with overrides to the default LEAFLET_CONFIG settings. | |||
(Default: {}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dict to override the default...
Nice contribution ! Thanks ! Would you mind adding a small test case please ? |
OK, I will try. |
Now it is with the test. |
Thanks a lot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to set DEFAULT_CENTER and DEFAULT_ZOOM depending on the user city location. Here are changes which allow to set LEAFLET_CONFIG overrides in LeafletWidget init parameter. Documentation of this is also part of the PR.