-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 support #53
Python3 support #53
Conversation
…s from the old urlparse module in Python 2. Use urlpars django.utils.six.moves.urllib.*.
…s and explicit relative imports are supported in Python 3
Hey many thanks for this ! Can you explain why you switched to postgis for running tests ? ( just wondering ) If you need help for travis and multiple python versions, just ask, we could setup tox. |
hi, https://travis-ci.org/itbabu/django-leaflet/jobs/17015425 $ pip install git+git://github.com/tinio/pysqlite.git@extension-enabled#egg=pysqlite
Downloading/unpacking pysqlite from git+git://github.com/tinio/pysqlite.git@extension-enabled
Cloning git://github.com/tinio/pysqlite.git (to extension-enabled) to /home/travis/virtualenv/python3.3/build/pysqlite
Running setup.py egg_info for package pysqlite
Traceback (most recent call last):
File "<string>", line 16, in <module>
File "/home/travis/virtualenv/python3.3/lib/python3.3/codecs.py", line 301, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 98: invalid continuation byte
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "<string>", line 16, in <module>
File "/home/travis/virtualenv/python3.3/lib/python3.3/codecs.py", line 301, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 98: invalid continuation byte I was able to pass the tests with python2.7 and Django1.6 / Django 1.5 (here) But then later (here) Travis got a 503 from external services and it failed before running the tests. |
Tests pass on Python3 too. |
@leplatrem This should be ready for review.
Notes: |
'django.contrib.auth', | ||
'django.contrib.contenttypes', | ||
'django.contrib.sessions', | ||
'django.contrib.admin', | ||
) | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why switch to list ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.apps
is a list now so I cannot concatenate it to a tuple.
I like it very much ! Thank you ! This is amazing :) I wrote a couple of remarks, but those are details... |
I'm working on Python 3 support.
This pull request is not ready yet.
First I need to see how tests run with Travis (I wasn't able to run them on my fork) :)