Update crosstab to support more types of input #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tests for both SQL Alchemy Core and SQL Alchemy ORM. - Tests cover getting all data, filtering, and aggregating. - Some patches to crosstab were required for ORM. - Added requirements.txt for pip usage. - Added Travis config for automatically testing on many versions.
* Add psycopg2 to requirements. * Attempt to add tablefunc extension to Travis CI test DB. * Attempt #2 to add tablefunc extension to Travis CI test DB. * Adding name to crosstab because CI wants it. * Generalize SQLite exception, because it varies between platforms. * Tweak how matrix was handled, since it seemed to be invalid. * Remove attempts to use multipl versions of PostgreSQL; it won't work.
|
@proegssilb Wow! I'm extremely grateful for this and super touched that you took the time to contribute back! Give me a day or two to review / test this over the weekend. It's been a while since I touched this code! |
|
@proegssilb 🍰 !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed
crosstabsupport for generating graphs in a SQL Alchemy ORM project, so I thought I'd share the code.Major changes:
crosstab.Columns in the Return Def. This allows me to use the same crosstab code multiple times in the sameSessionwithout having to generate a new table name. Generating a new table for each request could add up over the course of days or months in a web server (ie, memory leak). Depends on details.ASclause. Generic selectables andQueryobjects don't have a name, and I couldn't find a SQLA way to generate a unique name, so I removed the return value name (in theASclause) from the compilation. Works on 9.6, and works in CI, so I'm not sure why the docs consistently include a name. Being able to get a compiled name from.aliaswould be a great way to make this work, if I was smart enough to figure it out. I tried various manipulations ofAlias.name, but there's some extra machinery going on there I don't understand.Queryobjects instmtandcategoriesarguments. For ORM projects, that's a major source of cleaner code. Still not perfect, but I think the tests show a pretty good way to use the new code.Less major changes:
requirements.txtfor better dependency control. Just makes life easier.envfile.txtin tests. Because Windows doesn't really handle environment variables well, and a file ignored by git is not the worst place to stick a DB Connection String.