Bug fixing in access_split and functional_split.

The drawback of making independent projects: the same fix has to go into
multiple places. In this case (in both projects):

- Allow rating to be omitted in reviews (the model requires None, the
  form was normalising to "").
- I was confusing review.id and review.author_id when pulling out
  authors and it was only by accident that this wasn't causing problems
  earlier.

access_split/reviews/views.py

@@ -36,6 +36,12 @@ def __init__(self, *args, **kwargs):
             cache.set(self._cache_key, prod_choices)
         self.fields["product"].choices = prod_choices
 
+    def clean_rating(self):
+        value = self.cleaned_data["rating"]
+        if value == u"":
+            return None
+        return value
+
 
 def add_review(request, product_id=None):
     """
@@ -114,8 +120,8 @@ def product_reviews(request, product_id=None):
     product_list = products.models.Product.objects.order_by("name")
     review_qs = review_mgr.order_by("-created")
     review_dict = {}
-    review_ids = [obj.id for obj in review_qs]
-    users = dict(auth_models.User.objects.filter(id__in=review_ids). \
+    author_ids = [obj.author_id for obj in review_qs]
+    users = dict(auth_models.User.objects.filter(id__in=author_ids). \
             values_list("id", "username"))
     users[-1] = "Anonymous"
     for review in review_qs:

functional_split/reviews/views.py

@@ -33,6 +33,12 @@ def __init__(self, *args, **kwargs):
             cache.set(self._cache_key, prod_choices)
         self.fields["product"].choices = prod_choices
 
+    def clean_rating(self):
+        value = self.cleaned_data["rating"]
+        if value == u"":
+            return None
+        return value
+
 
 def add_review(request, product_id=None):
     """
@@ -96,8 +102,8 @@ def product_reviews(request, product_id=None):
     product_list = products.models.Product.objects.order_by("name")
     review_qs = reviews.models.Review.objects.order_by("-created")
     review_dict = {}
-    review_ids = [obj.id for obj in review_qs]
-    users = dict(auth_models.User.objects.filter(id__in=review_ids). \
+    author_ids = [obj.author_id for obj in review_qs]
+    users = dict(auth_models.User.objects.filter(id__in=author_ids). \
             values_list("id", "username"))
     users[-1] = "Anonymous"
     for review in review_qs: